Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pretty-printing of $crate (take 4) #62393

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Fix pretty-printing of $crate (take 4) #62393

merged 4 commits into from
Jul 10, 2019

Commits on Jul 9, 2019

  1. Add a test for $crate inside macro invocation

    @petrochenkov
    petrochenkov committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    7aaf0de View commit details
    Browse the repository at this point in the history

  2. Pretty-print $crate as crate/::my_crate in tokens 

    ...but only if those tokens are printed from inside of AST pretty-printing.
    @petrochenkov
    petrochenkov committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    4344a90 View commit details
    Browse the repository at this point in the history

  3. Resolve $crate in all hygienic contexts for pretty-pringing 

    Stop visiting AST to discover those contexts, just iterate through hygiene data instead
    @petrochenkov
    petrochenkov committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    3997507 View commit details
    Browse the repository at this point in the history

  4. Add a test case with $crate from other crate

    @petrochenkov
    petrochenkov committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    4cb67c0 View commit details
    Browse the repository at this point in the history