Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use GNU noexec stack note #61538

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Don't use GNU noexec stack note #61538

merged 1 commit into from
Jun 5, 2019

Conversation

coypoop
Copy link
Contributor

@coypoop coypoop commented Jun 5, 2019

NetBSD ignores this note and marks the stack no-exec unconditionally

NetBSD ignores this note and marks the stack no-exec unconditionally
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2019
@jonas-schievink jonas-schievink added the O-netbsd Operating system: NetBSD label Jun 5, 2019
@alexcrichton
Copy link
Member

@bors: r+

@alexcrichton
Copy link
Member

@bors: rollup

@bors
Copy link
Contributor

bors commented Jun 5, 2019

📌 Commit 77e9335 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 5, 2019
Don't use GNU noexec stack note

NetBSD ignores this note and marks the stack no-exec unconditionally
bors added a commit that referenced this pull request Jun 5, 2019
Rollup of 5 pull requests

Successful merges:

 - #61503 (Fix cfg(test) build for x86_64-fortanix-unknown-sgx)
 - #61534 (Edit docs of ExitStatus)
 - #61536 (Don't allow using const fn arguments as "args_required_const")
 - #61538 (Don't use GNU noexec stack note)
 - #61546 (azure: Fix some minor issues which have broken our configuration )

Failed merges:

r? @ghost
@bors bors merged commit 77e9335 into rust-lang:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-netbsd Operating system: NetBSD S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants