Remove 'Local Variable' comments #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graydon Is this OK? |
|
Eh. I liked having these settings enforced but I guess most of it is done by tidy these days. Sure. |
|
@graydon I just found it was weird that it was so inconsistently used. I'm also guessing we want to be editor agnostic – many people use Vim and some use Sublime Text, Kate or gedit. Is there anything in these comments that isn't covered by tidy? |
|
I had to rebase this due to a merge failure. |
bors
added a commit
that referenced
this pull request
May 2, 2013
I have noticed these comments scattered across the codebase. They appear to be vestigial Emacs formatting settings and they don't appear in newer files. For the sake of consistency it's probably best to remove them.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2020
Preserve raw strs for: format!(s) to s.to_string() lint fixes rust-lang#6142 clippy::useless_format will keep the source's string (after converting {{ and }} to { and }) when suggesting a change from format!() to .to_string() usage. Ie: | let s = format!(r#""hello {{}}""#); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `r#""hello {}""#.to_string()` changelog: [`useless_format`]: preserve raw string literals when no arguments to `format!()` are provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed these comments scattered across the codebase. They appear to be vestigial Emacs formatting settings and they don't appear in newer files. For the sake of consistency it's probably best to remove them.