The null case of a nullable-poiner enum might not be nullary. #6134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cases like `Either<@int,()>` have a null case with at most one value but a nonzero number of fields; if we misreport this, then bad things can happen inside of, for example, pattern matching. Closes rust-lang#6117.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
Check when `from_utf8` is called from sliced byte array from string --- *Please keep the line below* changelog: Fix rust-lang#5487: Add linter to check when `from_utf8` is called from sliced byte array from string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases like
Either<@int,()>have a null case with at most one value buta nonzero number of fields; if we misreport this, then bad things can
happen inside of, for example, pattern matching.
Closes #6117.