Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak macro parse errors when reaching EOF during macro call parse #61026

Merged
merged 5 commits into from
May 25, 2019
Merged

Tweak macro parse errors when reaching EOF during macro call parse #61026

merged 5 commits into from
May 25, 2019

Commits on May 24, 2019

  1. Tweak macro parse errors when reaching EOF during macro call parse 

    - Add detail on origin of current parser when reaching EOF and stop
  saying "found <eof>" and point at the end of macro calls
- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
    @estebank
    estebank committed May 24, 2019
    Configuration menu
    Copy the full SHA
    2416017 View commit details
    Browse the repository at this point in the history

  2. review comments

    @estebank
    estebank committed May 24, 2019
    Configuration menu
    Copy the full SHA
    5c5fa77 View commit details
    Browse the repository at this point in the history

  3. Fix rebase

    @estebank
    estebank committed May 24, 2019
    Configuration menu
    Copy the full SHA
    a2f853a View commit details
    Browse the repository at this point in the history

  4. Move diagnostic logic out of parser

    @estebank
    estebank committed May 24, 2019
    Configuration menu
    Copy the full SHA
    da57ac3 View commit details
    Browse the repository at this point in the history

  5. Revert changes that belong to separate PR

    @estebank
    estebank committed May 24, 2019
    Configuration menu
    Copy the full SHA
    ee7593e View commit details
    Browse the repository at this point in the history