-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use delay_span_bug
for error cases when checking AnonConst
parent
#60710
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/test/ui/const-generics/cannot-infer-type-for-const-param.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#![feature(const_generics)] | ||
//~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash | ||
|
||
// We should probably be able to infer the types here. However, this test is checking that we don't | ||
// get an ICE in this case. It may be modified later to not be an error. | ||
|
||
struct Foo<const NUM_BYTES: usize>(pub [u8; NUM_BYTES]); | ||
|
||
fn main() { | ||
let _ = Foo::<3>([1, 2, 3]); //~ ERROR type annotations needed | ||
} |
15 changes: 15 additions & 0 deletions
15
src/test/ui/const-generics/cannot-infer-type-for-const-param.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
warning: the feature `const_generics` is incomplete and may cause the compiler to crash | ||
--> $DIR/cannot-infer-type-for-const-param.rs:1:12 | ||
| | ||
LL | #![feature(const_generics)] | ||
| ^^^^^^^^^^^^^^ | ||
|
||
error[E0282]: type annotations needed | ||
--> $DIR/cannot-infer-type-for-const-param.rs:10:19 | ||
| | ||
LL | let _ = Foo::<3>([1, 2, 3]); | ||
| ^ cannot infer type for `{integer}` | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0282`. |
9 changes: 9 additions & 0 deletions
9
src/test/ui/const-generics/invalid-const-arg-for-type-param.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
use std::convert::TryInto; | ||
|
||
struct S; | ||
|
||
fn main() { | ||
let _: u32 = 5i32.try_into::<32>().unwrap(); //~ ERROR wrong number of const arguments | ||
S.f::<0>(); //~ ERROR no method named `f` | ||
S::<0>; //~ ERROR wrong number of const arguments | ||
} |
25 changes: 25 additions & 0 deletions
25
src/test/ui/const-generics/invalid-const-arg-for-type-param.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
error[E0107]: wrong number of const arguments: expected 0, found 1 | ||
--> $DIR/invalid-const-arg-for-type-param.rs:6:34 | ||
| | ||
LL | let _: u32 = 5i32.try_into::<32>().unwrap(); | ||
| ^^ unexpected const argument | ||
|
||
error[E0599]: no method named `f` found for type `S` in the current scope | ||
--> $DIR/invalid-const-arg-for-type-param.rs:7:7 | ||
| | ||
LL | struct S; | ||
| --------- method `f` not found for this | ||
... | ||
LL | S.f::<0>(); | ||
| ^ | ||
|
||
error[E0107]: wrong number of const arguments: expected 0, found 1 | ||
--> $DIR/invalid-const-arg-for-type-param.rs:8:9 | ||
| | ||
LL | S::<0>; | ||
| ^ unexpected const argument | ||
|
||
error: aborting due to 3 previous errors | ||
|
||
Some errors have detailed explanations: E0107, E0599. | ||
For more information about an error, try `rustc --explain E0107`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if this is replaced with
3usize
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it ICEs:
I think this is probably a result of the existing issues with const generics and arrays. I'll add the updated test as a new issue.