Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize vecdeque_rotate #60678

Merged
merged 2 commits into from
May 19, 2019
Merged

Stabilize vecdeque_rotate #60678

merged 2 commits into from
May 19, 2019

Conversation

DutchGhost
Copy link
Contributor

This PR stabilizes the vecdeque_rotate feature.
r? @scottmcm

Closes #56686

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2019
@DutchGhost DutchGhost changed the title Stableize vecdeque_rotate Stabilize vecdeque_rotate May 9, 2019
@scottmcm scottmcm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label May 9, 2019
@scottmcm
Copy link
Member

scottmcm commented May 9, 2019

Marked blocked on the FCP in the tracking issue (for another 9-ish days)

@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 9, 2019
@Centril Centril added this to the 1.36 milestone May 9, 2019
@Centril Centril added relnotes Marks issues that should be documented in the release notes of the next release. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2019
@scottmcm
Copy link
Member

Looks like the FCP finished uneventfully (thanks for tag fixing @Centril), so

@bors r+ rollup

Thanks for the PR, @DutchGhost!

@bors
Copy link
Contributor

bors commented May 18, 2019

📌 Commit 4d03399 has been approved by scottmcm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 18, 2019
Centril added a commit to Centril/rust that referenced this pull request May 19, 2019
Stabilize vecdeque_rotate

This PR stabilizes the vecdeque_rotate feature.
r? @scottmcm

Closes rust-lang#56686
bors added a commit that referenced this pull request May 19, 2019
Rollup of 8 pull requests

Successful merges:

 - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const)
 - #60678 (Stabilize vecdeque_rotate)
 - #60924 (Explain that ? converts the error type using From)
 - #60931 (Use iter() for iterating arrays by slice)
 - #60934 (Declare DefIndex with the newtype_index macro)
 - #60943 (fix copy-paste typo in docs for ptr::read_volatile)
 - #60945 (Simplify BufRead::fill_buf doc example using NLL)
 - #60947 (Fix typos in docs of GlobalAlloc)

Failed merges:

r? @ghost
@bors bors merged commit 4d03399 into rust-lang:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for VecDeque::rotate_{left|right} (feature vecdeque_rotate)
5 participants