-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instead of ICEing on incorrect pattern, use delay_span_bug #60641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 8, 2019
@bors r+ |
📌 Commit cc40f41 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 8, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 8, 2019
Instead of ICEing on incorrect pattern, use delay_span_bug Fix rust-lang#60635.
bors
added a commit
that referenced
this pull request
May 8, 2019
Rollup of 8 pull requests Successful merges: - #59979 (to_xe_bytes for isize and usize returns an array of different size) - #60491 (std: Update compiler-builtins crate) - #60550 (Add tests for concrete const types) - #60572 (Add test for #59972) - #60627 (test for #50518) - #60634 (Document + Cleanup lang_items.rs) - #60641 (Instead of ICEing on incorrect pattern, use delay_span_bug) - #60644 (Use `delay_span_bug` for "Failed to unify obligation") Failed merges: r? @ghost
estebank
added
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
May 9, 2019
discussed at T-compiler meeting. accepted for beta-backport. |
pnkfelix
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
May 16, 2019
pietroalbini
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
May 17, 2019
bors
added a commit
that referenced
this pull request
May 18, 2019
[beta] Rollup backports Rolled up: * [beta] save-analysis: Pull associated type definition using `qpath_def` #60881 * [beta] Update clippy #60918 Cherry-picked: * Instead of ICEing on incorrect pattern, use delay_span_bug #60641 * Use `delay_span_bug` for "Failed to unify obligation" #60644 r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60635.