Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from fc96aa03 to 341c96af #60626

Merged
merged 1 commit into from
May 8, 2019

Conversation

matthiaskrgr
Copy link
Member

Fixes clippy toolstate

Fixes #60623

Changes:

rustup https://github.com/rust-lang/rust/pull/60586
Add test for #771.
Clean up while_loop tests

r? @Manishearth

Changes:
````
rustup rust-lang#60586
Add test for rust-lang#771.
Clean up while_loop tests
````
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2019
@Manishearth
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 8, 2019

📌 Commit 152b26a has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2019
@bors
Copy link
Contributor

bors commented May 8, 2019

⌛ Testing commit 152b26a with merge 6a2bac2819a17f4d4142e8c89af8bd2d0746eeba...

@bors
Copy link
Contributor

bors commented May 8, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2019
@matthiaskrgr
Copy link
Member Author

Uhm..

running 10 tests
test builder::__test::build_default ... ok
test builder::__test::build_with_target_flag ... ok
test builder::__test::dist_baseline ... FAILED
test builder::__test::dist_with_hosts ... ok
test builder::__test::dist_with_same_targets_and_hosts ... ok
test builder::__test::dist_with_target_flag ... ok
test builder::__test::dist_with_targets ... ok
test builder::__test::dist_with_targets_and_hosts ... ok
test builder::__test::test_exclude ... ok
test builder::__test::test_with_no_doc_stage0 ... ok
failures:
---- builder::__test::dist_baseline stdout ----
git could not determine the LLVM submodule commit hash. Assuming that an LLVM build is necessary.
thread 'main' panicked at 'command did not execute successfully: "\\\\?\\C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "install" "--list"
expected success, got: exit code: 0xc0000005', src\build_helper\lib.rs:134:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failures:
    builder::__test::dist_baseline
test result: FAILED. 9 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--lib'
command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "test" "--" "--test-threads=1"
expected success, got: exit code: 101
failed to run: C:\projects\rust\build\bootstrap\debug\bootstrap test
Build completed unsuccessfully in 1:53:27
Command exited with code 1

@oli-obk
Copy link
Contributor

oli-obk commented May 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 8, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Optimize HIR map #60246

@bors
Copy link
Contributor

bors commented May 8, 2019

📌 Commit 152b26a has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2019
@bors
Copy link
Contributor

bors commented May 8, 2019

⌛ Testing commit 152b26a with merge e630580...

bors added a commit that referenced this pull request May 8, 2019
submodules: update clippy from fc96aa0 to 341c96a

Fixes clippy toolstate

Fixes #60623

Changes:
````
rustup #60586
Add test for #771.
Clean up while_loop tests
````

r? @Manishearth
@bors
Copy link
Contributor

bors commented May 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing e630580 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2019
@bors bors merged commit 152b26a into rust-lang:master May 8, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #60626!

Tested on commit e630580.
Direct link to PR: #60626

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 8, 2019
Tested on commit rust-lang/rust@e630580.
Direct link to PR: <rust-lang/rust#60626>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
@Xanewok
Copy link
Member

Xanewok commented May 8, 2019

@matthiaskrgr thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#60586
6 participants