Cleanup 'active' declare_features! with uniform style + sorting. #60362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 28, 2019
oli-obk
reviewed
Apr 29, 2019
|
|
||
| // Allows default type parameters to influence type inference. | ||
| (active, default_type_parameter_fallback, "1.3.0", Some(27336), None), | ||
| // FIXME: Document these and merge with the list below. |
There was a problem hiding this comment.
why did you move this list?
There was a problem hiding this comment.
It didn't fit with the other groupings which are sorted lists so I moved here temporarily and hopefully @gnzlbg can help me reintegrate it later.
| // Allows using the `may_dangle` attribute (RFC 1327). | ||
| (active, dropck_eyepatch, "1.10.0", Some(34761), None), | ||
|
|
||
| // Allows the use of custom attributes (RFC 572). | ||
| (active, custom_attribute, "1.0.0", Some(29642), None), | ||
| // Allows using `#[structural_match]` which indicates that a type is structurally matchable. |
There was a problem hiding this comment.
Suggested change
| // Allows using `#[structural_match]` which indicates that a type is structurally matchable. | |
| // Allows using `#[structural_match]` which indicates that constants of that type | |
| // may be used in patterns |
There was a problem hiding this comment.
I believe #[structural_match] does / will do more than this; See: https://github.com/rust-lang/rfcs/blob/master/text/2000-const-generics.md#structural-equality wherein #[structural_match] is required for const generics; cc @varkor cc #60286
Centril
force-pushed
the
cleanup-declare-features-active
branch
from
71faa9f
to
3c00dfd
Compare
|
@bors r+ |
|
📌 Commit 3c00dfd has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…cepted, r=oli-obk Cleanup declare_features! for 'accepted' with a uniform style + sort them r? @oli-obk cc rust-lang#60362 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…tive, r=oli-obk Cleanup 'active' declare_features! with uniform style + sorting. r? @oli-obk (added the FIXME you wanted) cc rust-lang#60354 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…cepted, r=oli-obk Cleanup declare_features! for 'accepted' with a uniform style + sort them r? @oli-obk cc rust-lang#60362 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…tive, r=oli-obk Cleanup 'active' declare_features! with uniform style + sorting. r? @oli-obk (added the FIXME you wanted) cc rust-lang#60354 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…cepted, r=oli-obk Cleanup declare_features! for 'accepted' with a uniform style + sort them r? @oli-obk cc rust-lang#60362 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…tive, r=oli-obk Cleanup 'active' declare_features! with uniform style + sorting. r? @oli-obk (added the FIXME you wanted) cc rust-lang#60354 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…cepted, r=oli-obk Cleanup declare_features! for 'accepted' with a uniform style + sort them r? @oli-obk cc rust-lang#60362 cc rust-lang#60361
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…tive, r=oli-obk Cleanup 'active' declare_features! with uniform style + sorting. r? @oli-obk (added the FIXME you wanted) cc rust-lang#60354 cc rust-lang#60361
bors
added a commit
that referenced
this pull request
Apr 30, 2019
Rollup of 7 pull requests Successful merges: - #60344 (Don't try to render auto-trait bounds with any inference variables) - #60354 (Cleanup declare_features! for 'accepted' with a uniform style + sort them) - #60362 (Cleanup 'active' declare_features! with uniform style + sorting.) - #60382 (Revert "Update Source Code Pro fonts to version 2.030") - #60399 (Update clippy) - #60400 (Remove functions to simplify handling of feature(bind_by_move_pattern_guards)) - #60408 (Add missing f16c_target_feature check to typeck collect) Failed merges: r? @ghost
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 2, 2019
… r=Centril Tidy: ensure lang features are sorted by since This is the tidy side of rust-lang#60361. What is left is actually splitting features into groups and sorting by since. This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
… r=Centril Tidy: ensure lang features are sorted by since This is the tidy side of rust-lang#60361. What is left is actually splitting features into groups and sorting by since. This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
… r=Centril Tidy: ensure lang features are sorted by since This is the tidy side of rust-lang#60361. What is left is actually splitting features into groups and sorting by since. This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362. r? @Centril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
(added the FIXME you wanted)
cc #60354
cc #60361