-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clippy #60355
Update clippy #60355
Conversation
|
Not familiar with Clippy's codebase; r? @oli-obk |
It's just a rustup; this is bumping clippy to the new master version. As long as it matches a commit in clippy master it should be fine. |
Review for these is basically a formality since it's already been reviewed on the clippy side |
@Manishearth Uhm; okay... I guess... but If it is just a formality just r+ yourself :) |
📌 Commit 64d62bdc225c819b58a1126b731e8b17063793f2 has been approved by |
Wasn't sure if that was okay. Then again, we already do that for rollups so shrug |
@bors p=1 |
⌛ Testing commit 64d62bdc225c819b58a1126b731e8b17063793f2 with merge 01d44d4d93cfba19b2e338ded734d4114b1ed3fa... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
4890769
to
3635bfa
Compare
@bors r=Centril |
📌 Commit 3635bfa has been approved by |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=centril seems unrelated? |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 505cae2 has been approved by |
@bors retry |
☀️ Test successful - checks-travis, status-appveyor |
📣 Toolstate changed by #60355! Tested on commit a55c2eb. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
Tested on commit rust-lang/rust@a55c2eb. Direct link to PR: <rust-lang/rust#60355> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 🎉 rls on windows: build-fail → test-fail (cc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
r? @Centril