impl From<Infallible> for TryFromSliceError

[jethrogb]

I believe this was missed when TryFrom was stabilized. I think TryFromSliceError and TryFromIntError are the only two TryFrom error types that appear in std. I think trait implementations have to be insta-stable, but I'm not sure.

[rust-highfive]

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:26d0edb4:start=1556308197659287217,finish=1556308198435658759,duration=776371542
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:03:54]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:03:58] error[E0412]: cannot find type `Infallible` in this scope
[00:03:58]   --> src/libcore/array.rs:76:11
[00:03:58]    |
[00:03:58] 76 | impl From<Infallible> for TryFromSliceError {
[00:03:58] help: possible candidate is found in another module, you can import it into scope
[00:03:58]    |
[00:03:58] 12 | use crate::convert::Infallible;
[00:03:58]    |
[00:03:58]    |
[00:03:58] 
[00:03:58] error[E0412]: cannot find type `Infallible` in this scope
[00:03:58]   --> src/libcore/array.rs:77:16
[00:03:58]    |
[00:03:58] 77 |     fn from(x: Infallible) -> TryFromSliceError {
[00:03:58] help: possible candidate is found in another module, you can import it into scope
[00:03:58]    |
[00:03:58] 12 | use crate::convert::Infallible;
[00:03:58]    |
---
travis_time:end:02a98280:start=1556308463490887061,finish=1556308463495250691,duration=4363630
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16cfd913
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05b91784
travis_time:start:05b91784
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0d6f5f9e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:35499234:start=1556308605357371460,finish=1556308606099424323,duration=742052863
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:04:08]    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:04:24] error[E0711]: feature `try_from` is declared stable since 1.36.0, but was previously declared stable since 1.34.0
[00:04:24]   --> src/libcore/array.rs:75:1
[00:04:24]    |
[00:04:24] 75 | #[stable(feature = "try_from", since = "1.36.0")]
[00:04:24] 
[00:04:24] error: aborting due to previous error
[00:04:24] 
[00:04:24] For more information about this error, try `rustc --explain E0711`.
---
travis_time:end:0d96e1d0:start=1556308882904880792,finish=1556308882910133810,duration=5253018
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0434e5d6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:13db7300
travis_time:start:13db7300
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1e6afcfc
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[jethrogb]

Should I change the stability attribute to say 1.34 or add a new feature that's stable at 1.36?

[cramertj]

r? @SimonSapin

[SimonSapin]

1.36 is correct, as it is the current version in Nightly.

@bors r+

[bors]

📌 Commit 48b3f3d4ce010d9d9039908cfaba4ede00accbf0 has been approved by SimonSapin

[bors]

⌛ Testing commit 48b3f3d4ce010d9d9039908cfaba4ede00accbf0 with merge 65631a3665ff5bd4ae39a468c94b081d781dd428...

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:01]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:05:16] error[E0711]: feature `try_from` is declared stable since 1.36.0, but was previously declared stable since 1.34.0
[00:05:16]   --> src/libcore/array.rs:75:1
[00:05:16]    |
[00:05:16] 75 | #[stable(feature = "try_from", since = "1.36.0")]
[00:05:16] 
[00:05:16] error: aborting due to previous error
[00:05:16] 
[00:05:16] For more information about this error, try `rustc --explain E0711`.
---
travis_time:end:11e37dfe:start=1556415923161285422,finish=1556415923168176238,duration=6890816
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04bf50d2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01b327d2
travis_time:start:01b327d2
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:039561f2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[jethrogb]

@SimonSapin, nope see CI error.

[SimonSapin]

@jethrogb You need to pick a different feature name. (The name doesn’t matter to much, IIRC think it doesn’t show up anywhere.)

[jethrogb]

Updated

[Centril]

r? @sfackler

[sfackler]

@bors r+

[bors]

📌 Commit 24d89e5 has been approved by sfackler

[bors]

⌛ Testing commit 24d89e5 with merge af98304...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: sfackler
Pushing af98304 to master...

[briansmith]

Note: Every time I've received the error "TryFromSliceError does not implement From<Infallible>" it was because I was calling try_into() on a non-slice object and it was a bug in my code. I wonder if these will cause buggy code to start compiling? Maybe that's why they weren't originally added?