Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #60208

Closed
wants to merge 22 commits into from
Closed

Commits on Apr 10, 2019

  1. Configuration menu
    Copy the full SHA
    53d2473 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23154db View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2019

  1. Configuration menu
    Copy the full SHA
    e14819a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bafc58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cdca41d View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. Configuration menu
    Copy the full SHA
    517fb1b View commit details
    Browse the repository at this point in the history
  2. Add rustc_allow_const_fn_ptr

    cramertj committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    e55a313 View commit details
    Browse the repository at this point in the history
  3. Stabilize futures_api

    cramertj committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    795a15a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Add f16c target_feature

    gnzlbg committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    2d401fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33f0a37 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    51b2ecf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6283897 View commit details
    Browse the repository at this point in the history
  5. Update ui tests

    varkor committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    497dcfa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7f7d15d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5392f44 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5ab5806 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#59739 - cramertj:stabilize, r=withoutboats

    Stabilize futures_api
    
    cc rust-lang#59725.
    Based on rust-lang#59733 and rust-lang#59119 -- only the last two commits here are relevant.
    
    r? @withoutboats , @oli-obk for the introduction of `rustc_allow_const_fn_ptr`.
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    76c7802 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#59839 - KodrAus:must-use-num, r=sfackler

    Warn on unused results for operation methods on nums
    
    From a suggestion by @llogiq
    
    Adds a `#[must_use]` attribute to operation methods on integers that take self by value as the first operand and another value as the second. It makes it clear that these methods return the result of the operation instead of mutating `self`, which is the source of a rather embarrassing bug I had in a codebase of mine recently...
    
    As an example:
    
    ```rust
    struct Int {
       value: i64,
    }
    
    impl Int {
        fn add(&mut self, other: i64) {
            self.value.wrapping_add(other);
        }
    }
    ```
    
    Will produce a warning like:
    
    ```
    warning: unused return value of `core::num::<impl i64>::wrapping_add` that must be used
     --> src/main.rs:7:7
      |
    7 |       self.value.wrapping_add(other);
      |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: #[warn(unused_must_use)] on by default
      = note: this returns the result of the operation, without modifying the original
    ```
    
    If this is something we're on board with, we could do something similar for `f32` and `f64` too. There are probably other methods on integers that make sense.
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    4f125a6 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#60146 - Manishearth:font-update, r=QuietMis…

    …dreavus
    
    Update fonts used by rustdoc
    
    Our version of Source Serif Pro is pretty old and is causing issues on Linux, see https://bugzilla.mozilla.org/show_bug.cgi?id=1545317 . I took this opportunity to update all of the fonts we use.
    
    r? @steveklabnik @QuietMisdreavus
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    1d2276f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#60169 - varkor:tidy-unnecessary-ignore-newl…

    …ine, r=kennytm
    
    Warn when ignore-tidy-linelength is present, but no lines are too long
    
    It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    3006800 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#60177 - rasendubi:rustdoc-comments, r=varkor

    Promote rust comments to rustdoc
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    1d64312 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#60191 - gnzlbg:f16c, r=alexcrichton

    Add f16c target_feature
    
    This is requires for Intel 16-bit half-precision float intrinsics: https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=fp16&expand=1769 - see companion stdsimd PR: rust-lang/stdarch#737.
    
    LLVM, Wikipedia CPUID page, and the Intel Dev Manual all call this CPUID feature "F16C", but the Intel intrinsics guide calls this "FP16C" - this is probably a bug in the intrinsics guide which we are tracking here: rust-lang/stdarch#738
    
    r? @alexcrichton
    Centril authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    97b74a5 View commit details
    Browse the repository at this point in the history