-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bootstrap compiler to 2019-04-11 #59974
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r=me once travis is green |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3ff5330
to
707e330
Compare
I bumped nightly to 1.36 but in the process I had to revert the @pietroalbini can you have another look? |
I expected a bunch more cfg's being removed; maybe I'm missing something? |
https://github.com/rust-lang/rust/blob/9cd61f025b1b92076e69a9ef2d9233325c7d8bdc/src/librustc/ty/mod.rs has an example of what I meant (I think that's actually the only case based on a quick search). |
EDIT: Rebased commit to remove accidental newline in With this commit it builds for me: |
r=me with that commit included |
@bors r=pietroalbini,Mark-Simulacrum p=1 |
📌 Commit 72b2f23 has been approved by |
⌛ Testing commit 72b2f23 with merge 6f32d743e117c6d58b1d5de9c120e814094c40ec... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
72b2f23
to
f2371e3
Compare
@bors r=pietroalbini,Mark-Simulacrum p=1 |
📌 Commit f2371e3 has been approved by |
…,Mark-Simulacrum Bump bootstrap compiler to 2019-04-11 r? @pietroalbini cc @Mark-Simulacrum cc #58702
☀️ Test successful - checks-travis, status-appveyor |
A PR should be opened with the backported commit and auto-accepted since it simply fixes a technical mistake. |
@Keruspe Can you file such a PR? |
@Centril sure, will do |
r? @pietroalbini
cc @Mark-Simulacrum
cc #58702