Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #59910

Merged
merged 33 commits into from
Apr 12, 2019
Merged

Rollup of 15 pull requests #59910

merged 33 commits into from
Apr 12, 2019

Commits on Apr 3, 2019

  1. Add documentation on the -Z flag on the command-line arguments sectio…

    …n in the rustc book.
    Christian committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    5c7a944 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. Configuration menu
    Copy the full SHA
    894142d View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. compiletest: Improve no_prefer_dynamic docs

    This adds some extra docs for the `no-prefer-dynamic` header.
    
    And also a `s/must_compile_successfully/compile_pass`.
    
    `must_compile_successfully` has been renamed to `compile_pass` at some
    point in the past and this comment was still referring to the old name.
    phansch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    edebed9 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Configuration menu
    Copy the full SHA
    9017d46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3262d1e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    757ef38 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e01901 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. std::ops::Div examples: correct nominator to numerator

    Signed-off-by: Anders Kaseorg <[email protected]>
    andersk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    3826493 View commit details
    Browse the repository at this point in the history
  2. Updated the documentation, now claiming the -Z is associated to unsta…

    …ble compiler flags, instead of flags for debugging.
    Christian committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    7acfa45 View commit details
    Browse the repository at this point in the history
  3. Updated the description of -Z in the rustc book.

    Christian committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    cdeb745 View commit details
    Browse the repository at this point in the history
  4. SGX target: fix cfg(test) build

    Jethro Beekman committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    e2d1d66 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Configuration menu
    Copy the full SHA
    0234878 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f54df44 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae2a68b View commit details
    Browse the repository at this point in the history
  4. Update diagnostics.rs

    Add `a` and other minor text improvements
    andrewbanchich authored Apr 11, 2019
    Configuration menu
    Copy the full SHA
    aefc158 View commit details
    Browse the repository at this point in the history
  5. Fix the link to sort_by_cached_key

    It's a primitive slice method, not a standalone function.
    cuviper authored Apr 11, 2019
    Configuration menu
    Copy the full SHA
    90d9727 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1ced262 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bcd263e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Rollup merge of rust-lang#59680 - DevQps:document-rustc-z-flag, r=cra…

    …mertj
    
    Document the -Z flag to the rustc book
    
    # Description
    
    Changes:
    - Added new documentation on the `-Z` flag of rustc in the command-line arguments section of the rustc book.
    
    If I need to rephrase anything or if you have any improvements, please let me know! I deliberately did not create an exhaustive list of all options since they are likely to change over time and per toolchain version.
    
    closes rust-lang#41142
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    59e95dd View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#59711 - GuillaumeGomez:substring-test, r=Qu…

    …ietMisdreavus
    
    Add back the substring test
    
    Fixes rust-lang#58331.
    
    r? @QuietMisdreavus
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d77b7d9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#59806 - phansch:compiletest_docs2, r=oli-obk

    compiletest: Improve no_prefer_dynamic docs
    
    This adds some extra docs for the `no-prefer-dynamic` header.
    
    And also a `s/must_compile_successfully/compile_pass`.
    
    `must_compile_successfully` has been renamed to `compile_pass` at some
    point in the past and this comment was still referring to the old name.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    2f71ecb View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#59809 - Zoxc:trait_methods_not_found, r=est…

    …ebank
    
    Make trait_methods_not_found use a lock
    
    r? @estebank
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f4c8cc9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#59811 - vext01:dead-dominator-code, r=oli-obk

    Kill dead code dominator code.
    
    Hi,
    
    Whilst fiddling around in the dominator code, I found some (I think) unused code. This code *was* used at the time it was imported, but over time it seems to have become redundant.
    
    I've tested a build up to stage 1 with no problems. Maybe the tests will turn up something though.
    
    P.S.
    
    There is a FIXME comment in `dominators/mod.rs`:
    ```
        pub fn is_dominated_by(&self, node: Node, dom: Node) -> bool {
            // FIXME -- could be optimized by using post-order-rank
            self.dominators(node).any(|n| n == dom)
        }
    ```
    
    I'm not sure of the intention of this comment. The `Dominators` struct already operates over post-order rank nodes. Any ideas?
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ba10b13 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#59814 - ollie27:dead_boxed_links, r=QuietMi…

    …sdreavus
    
    Fix broken links on std::boxed doc page
    
    r? @QuietMisdreavus
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    484e703 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#59821 - euclio:unknown-enum-variants, r=dav…

    …idtwco
    
    improve unknown enum variant errors
    
    Fixes rust-lang#56517.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    24ee611 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#59831 - ehuss:ordering-docs, r=kennytm

    Remove strange formatting in `Ordering` docs.
    
    I can't really fathom what the intent of the brackets is. The [original PR](rust-lang#12956) doesn't give any hints. I think it seems fine without them.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    94b7b6a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#59836 - andersk:nominator, r=Centril

    std::ops::Div examples: correct nominator to numerator
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    740c9ea View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#59857 - jethrogb:jb/sgx-test, r=Centril

    SGX target: fix cfg(test) build
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    c852cc5 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#59876 - integer32llc:update-trpl-to-mdbook-…

    …0.2, r=steveklabnik
    
    Update TRPL to use mdbook 0.2
    
    I ran linkchecker locally and it passed. Let's see if I did it correctly...
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ef90d94 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#59880 - solson:transmute-float, r=alexcrichton

    Remove note about transmute for float bitpatterns.
    
    This particular usecase has been safely abstracted in these `std` functions: [f32::to_bits](https://doc.rust-lang.org/std/primitive.f32.html#method.to_bits), [f32::from_bits](https://doc.rust-lang.org/std/primitive.f32.html#method.from_bits), [f64::to_bits](https://doc.rust-lang.org/std/primitive.f64.html#method.to_bits), [f64::from_bits](https://doc.rust-lang.org/std/primitive.f64.html#method.from_bits). So, I think we shouldn't recommend an unnecessary use of `unsafe` here anymore.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    257dbb8 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#59889 - andrewbanchich:minor-text-fixes, r=…

    …estebank
    
    Update diagnostics.rs
    
    Add `a` and other minor text improvements
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    cb7079f View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#59891 - rust-lang:sort_by_cached_key, r=jon…

    …as-schievink
    
    Fix the link to sort_by_cached_key
    
    It's a primitive slice method, not a standalone function.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    dddcd92 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#59894 - Xanewok:save-assoc-ty-qpath, r=eddyb

    save-analysis: Pull associated type definition using `qpath_def`
    
    Closes rust-lang/rls#1390
    
    This (probably?) fixes the case where we run the save-analysis code on the following snippet:
    ```rust
    trait Test<'a> {
        type Thing: Test2;
    }
    
    trait Test2 {
        fn print();
    }
    
    #[allow(unused)]
    fn example<T>(t: T)
        where T: for<'a> Test<'a>
    {
        T::Thing::print(); //~ ERROR cannot extract an associated type from a higher-ranked trait bound in this context
        // ^ only errors in save-analysis mode
    }
    ```
    
    The chain is as follows:
    - culprit is `hir_ty_to_ty`
    - which calls `ast_ty_to_ty` in the `ItemCtxt`
    - which calls `associated_path_to_ty`
    - which finally fails on `projected_ty_from_poly_trait_ref`
    https://github.com/rust-lang/rust/blob/3de0106789468b211bcc3a25c09c0cf07119186d/src/librustc_typeck/collect.rs#L212-L224
    
    I'm not exactly sure why `hir_ty_to_ty` fails - is it because it needs more setup from typeck to work correctly? I'm guessing the fix is okay since we just pull the already typeck'd data (we run save-analysis after all the analysis passes are complete) from the tables.
    
    With this change we can 'go to def' on all segments in the `T::Thing::print()` path.
    Centril authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    7a8329f View commit details
    Browse the repository at this point in the history