Add summary and reference to Rust trademark guide #59748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @skade Would you be willing to review this? |
|
This looks okay, with the extension that we also have a licenses page: https://www.rust-lang.org/policies/licenses I would add that as well. It's quite important, as some media (especially pictures) on the page are used with permission and not owned by the Rust team. |
|
Thanks for this! I agree with @skade , adding a link to that would be great as well. Thanks so much! |
|
Hi @skade @steveklabnik , |
|
@agnxy Perfect, thanks! r+ /cc @alexcrichton |
|
@bors: r=skade |
|
📌 Commit 98beb12 has been approved by |
bors
added
S-waiting-on-bors
|
@alexcrichton Please rollup PRs such as this :) @bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 15, 2019
Add summary and reference to Rust trademark guide Fix rust-lang#53287 cc @steveklabnik
bors
added a commit
that referenced
this pull request
Apr 15, 2019
Rollup of 6 pull requests Successful merges: - #59648 (Add must_use annotations to Result::is_ok and is_err) - #59748 (Add summary and reference to Rust trademark guide) - #59779 (Uplift `get_def_path` from Clippy) - #59955 (bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent) - #59978 (rustdoc: Remove default keyword from re-exported trait methods) - #59989 (Fix links to Atomic* in RELEASES.md) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #53287
cc @steveklabnik