-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable stack probing for gnux32. #59686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 4, 2019
luqmana
reviewed
Apr 4, 2019
r? @sanxiyn |
crlf0710
force-pushed
the
disable_gnux32_stackprobe
branch
from
April 4, 2019 06:40
9772daf
to
42d652e
Compare
Addressed the review comment above :) |
@bors r+ |
📌 Commit 42d652e has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 4, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 4, 2019
… r=luqmana Temporarily disable stack probing for gnux32.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 4, 2019
… r=luqmana Temporarily disable stack probing for gnux32.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 4, 2019
… r=luqmana Temporarily disable stack probing for gnux32.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 4, 2019
… r=luqmana Temporarily disable stack probing for gnux32.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 4, 2019
… r=luqmana Temporarily disable stack probing for gnux32.
bors
added a commit
that referenced
this pull request
Apr 4, 2019
Rollup of 8 pull requests Successful merges: - #59470 (Document std::fs::File close behavior ignoring errors) - #59555 (update miri) - #59556 (update stdsimd) - #59596 (Forward formatter settings to bounds of `Range<T>` in `fmt::Debug` impl) - #59639 (Never return uninhabited values at all) - #59671 (Make some of lexer's API private) - #59685 (Add description for -Os and -Oz in rustc.1) - #59686 (Temporarily disable stack probing for gnux32.) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 21, 2019
Revert "Disable stack probing for gnux32." This reverts commit 42d652e. (rust-lang#59686) Closes rust-lang#59674.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 22, 2019
Revert "Disable stack probing for gnux32." This reverts commit 42d652e. (rust-lang#59686) Closes rust-lang#59674.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 23, 2019
Revert "Disable stack probing for gnux32." This reverts commit 42d652e. (rust-lang#59686) Closes rust-lang#59674.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.