Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in todo()! comment #59491

Closed
wants to merge 2 commits into from
Closed

Fix typo in todo()! comment #59491

wants to merge 2 commits into from

Conversation

sftim
Copy link

@sftim sftim commented Mar 28, 2019

After #56348 got mentioned in This Week In Rust, I took a look—and spotted a typo. Here's a fix.

It doesn't look like this needs an issue; if I'm wrong, let me know and I'll make one.

Fixup for 9d408d9
Really tiny tweak, to help readability.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aidanhs (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2019
@sftim
Copy link
Author

sftim commented Mar 28, 2019

Already fixed in d339b89

@sftim sftim closed this Mar 28, 2019
@sftim sftim deleted the 20190327_typo_fix branch March 28, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants