Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InferenceFudger (née RegionFudger) #59415

Merged
merged 16 commits into from
Mar 27, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Mar 25, 2019

  • Rename RegionFudger (and related methods) to InferenceFudger.
  • Take integer and float inference variables into account.
  • Refactor types_created_since_snapshot and vars_created_since_snapshot with the new version of ena.
  • Some other refactoring in the area.

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2019
@rust-highfive

This comment has been minimized.

@varkor varkor changed the title Refactor RegionFudger Refactor InferenceFudger (née RegionFudger) Mar 25, 2019
@rust-highfive

This comment has been minimized.

Cargo.lock Show resolved Hide resolved
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comments addressed (or wait for @nikomatsakis' review)

src/librustc/infer/fudge.rs Outdated Show resolved Hide resolved
@eddyb
Copy link
Member

eddyb commented Mar 26, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2019

📌 Commit 2b4171bb967bb709326a4255f4dc06f70addae0b has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2019
@varkor
Copy link
Member Author

varkor commented Mar 26, 2019

@bors p=1
This is blocking #59008.

@bors
Copy link
Contributor

bors commented Mar 27, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout values_since_snapshot (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self values_since_snapshot --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging src/librustc_typeck/check/mod.rs
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 27, 2019
@varkor
Copy link
Member Author

varkor commented Mar 27, 2019

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Mar 27, 2019

📌 Commit 86d5a69 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2019
@bors
Copy link
Contributor

bors commented Mar 27, 2019

⌛ Testing commit 86d5a69 with merge 33ef0ba...

bors added a commit that referenced this pull request Mar 27, 2019
Refactor InferenceFudger (née RegionFudger)

- Rename `RegionFudger` (and related methods) to `InferenceFudger`.
- Take integer and float inference variables into account.
- Refactor `types_created_since_snapshot` and `vars_created_since_snapshot` with the [new version of ena](rust-lang/ena#21).
- Some other refactoring in the area.

r? @eddyb
@bors
Copy link
Contributor

bors commented Mar 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 33ef0ba to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants