Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves test::black_box to core::hint and fix black_box on wasm32 and asm.js #59336

Merged
merged 8 commits into from
Mar 28, 2019

Commits on Mar 25, 2019

  1. Moves test::black_box to core::hint

    This changes removes a cyclic dependency between the "test" and "libtest"
    crates, where "libtest" depends on "test" for "black_box", but "test" depends on
    "libtest" for everything else.
    
    I've chosen the "hint" module because there seems to be enough consensus in the
    discussion of RFC2360 that this module is where such an intrinsic would belong,
    but this PR does not implement that RFC! (note: if that RFC ever gets merged,
    the API, docs, etc. of this API will need to change).
    
    For backwards compatibility reasons I've chosen to also keep the "test" feature
    gate for these instead of adding a new feature gate. If we change the feature
    gate, we'll potentially all benchmarks, and while that's something that we could
    do, it seems unnecessary to do that now - if RFC2360 gets merged, we'll need to
    do that anyways.
    gnzlbg committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    f5d6b3a View commit details
    Browse the repository at this point in the history
  2. Remove dupplicated config

    gnzlbg committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    f244383 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfa76c4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24db517 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Configuration menu
    Copy the full SHA
    d189cab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ea57aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b6b489 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c127e8 View commit details
    Browse the repository at this point in the history