Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #59081

Closed
wants to merge 33 commits into from
Closed

Rollup of 15 pull requests #59081

wants to merge 33 commits into from

Commits on Mar 1, 2019

  1. librustc_interface: Update scoped-tls to 1.0

    Done previously as a part of
    rust-lang#58748
    Xanewok committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    204f087 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    196e021 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. core: ensure VaList passes improper_ctypes lint

    Ensure the core::ffi::VaList structure passes the improper_ctypes lint.
    dlrobertson committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    1243859 View commit details
    Browse the repository at this point in the history
  2. std: Spin for a global malloc lock on wasm32

    There's lots of comments in the code, but the main gist of this commit
    is that the acquisition of the global malloc lock on the
    `wasm32-unknown-unknown` target when threads are enabled will not spin
    on contention rather than block.
    alexcrichton committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    72958ac View commit details
    Browse the repository at this point in the history
  3. MIPS: add r6 support

    MIPS r6 is quite different with the previous version.
    It use some new target triples:
      mipsisa32r6-unknown-linux-gnu
      mipsisa32r6el-unknown-linux-gnu
      mipsisa64r6-unknown-linux-gnuabi64
      mipsisa64r6el-unknown-linux-gnuabi64
    
    This patch has been tested with Debian Port for mips64r6el,
    and the support of these triples also is included in llvm:
      https://reviews.llvm.org/rGe58c45a695f39004710b6ce940d489fee800dbd3
    wzssyqa committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    710988a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e8758b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Configuration menu
    Copy the full SHA
    00887f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e19b228 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Configuration menu
    Copy the full SHA
    0a505a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9aa89b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a03e20d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    967e7f4 View commit details
    Browse the repository at this point in the history
  5. review comments

    estebank committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    f690821 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. Fix ICE in MIR pretty printing

    A `Def::Variant` should be considered as a function in mir pretty
    printing. Each variant has a constructor that we must print.
    
    Given the following enum definition:
    
    ```
    pub enum TestMe {
        X(usize),
    }
    ```
    
    We will need to generate a constructor for the variant `X` with a
    signature that looks something like the following:
    
    ```
    fn TestMe::X(_1: usize) -> TestMe;
    ```
    dlrobertson committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    3a83cb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df4ea90 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4888b1f View commit details
    Browse the repository at this point in the history
  4. enabled too many tests

    RalfJung committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    52d9fa8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7285b56 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Configuration menu
    Copy the full SHA
    528d642 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#58788 - matthewjasper:compare-children, r=p…

    …nkfelix
    
    Make migrate mode work at item level granularity
    
    Migrate mode now works entirely at the item level rather than the body level,
    ensuring that we don't lose any errors in contained closures.
    
    Closes rust-lang#58776
    
    r? @pnkfelix
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3d60740 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#58789 - jordanrh1:update-compiler-builtins,…

    … r=sanxiyn
    
    Update compiler_builtins to 0.1.7 to get windows/arm fix
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    6c2f17b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#58829 - Xanewok:scoped-tls, r=Zoxc

    librustc_interface: Update scoped-tls to 1.0
    
    Done previously as a part of rust-lang#58748.
    
    r? @Zoxc
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    da9d662 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58848 - GuillaumeGomez:fix-cache-issues, r=…

    …Mark-Simulacrum
    
    Prevent cache issues on version updates
    
    Fixes rust-lang#58827.
    
    cc @rust-lang/infra
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    91df4f1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58855 - alexcrichton:wasm-multithreaded-all…

    …oc, r=fitzgen
    
    std: Spin for a global malloc lock on wasm32
    
    There's lots of comments in the code, but the main gist of this commit
    is that the acquisition of the global malloc lock on the
    `wasm32-unknown-unknown` target when threads are enabled will not spin
    on contention rather than block.
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    8c21a2b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

    …rochenkov
    
    Adds help message in error for invalid `impl for T` syntax
    
    Fixes rust-lang#56031.
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    90f7ffc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…

    …henkov
    
    Parse lifetimes that start with a number and give specific error
    
    Fix rust-lang#58786.
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    cfa209d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett

    core: ensure VaList passes improper_ctypes lint
    
    Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.
    
    Fixes: rust-lang#58280
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    d0ab135 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#58941 - wzssyqa:master, r=alexcrichton

    MIPS: add r6 support
    
    MIPS r6 is quite different with the previous version.
    It use some new target triples:
      mipsisa32r6-unknown-linux-gnu
      mipsisa32r6el-unknown-linux-gnu
      mipsisa64r6-unknown-linux-gnuabi64
      mipsisa64r6el-unknown-linux-gnuabi64
    
    This patch has been tested with Debian Port for mips64r6el,
    and the support of these triples also is included in llvm:
      https://reviews.llvm.org/rGe58c45a695f39004710b6ce940d489fee800dbd3
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    69a53d4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…

    …twco
    
    When encountetring `||{}()`, suggest the likely intended `(||{})()`
    
    Fix rust-lang#55851.
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    9ca6d6c View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#59036 - dlrobertson:fix_59021, r=estebank

    Fix ICE in MIR pretty printing
    
    A `Def::Variant` should be considered as a function in mir pretty
    printing. Each variant has a constructor that we must print.
    
    Given the following enum definition:
    
    ```rust
    pub enum TestMe {
        X(usize),
    }
    ```
    
    We will need to generate a constructor for the variant `X` with a
    signature that looks something like the following:
    
    ```
    fn TestMe::X(_1: usize) -> TestMe;
    ```
    
    Fixes: rust-lang#59021
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3e02b45 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#59047 - petrochenkov:modnodefid, r=Centril

    resolve: Account for new importable entities
    
    Fixes the ICE encountered in rust-lang#58837
    r? @Centril
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    2c136f6 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#59056 - scottmcm:even-fewer-lifetimes, r=sf…

    …ackler
    
    Use lifetime contravariance to elide more lifetimes in core+alloc+std
    
    Sample:
    ```diff
    -    impl<'a, 'b, A: ?Sized, B: ?Sized> PartialEq<&'b mut B> for &'a mut A where A: PartialEq<B> {
    +    impl<A: ?Sized, B: ?Sized> PartialEq<&mut B> for &mut A where A: PartialEq<B> {
             #[inline]
    -        fn eq(&self, other: &&'b mut B) -> bool { PartialEq::eq(*self, *other) }
    +        fn eq(&self, other: &&mut B) -> bool { PartialEq::eq(*self, *other) }
             #[inline]
    -        fn ne(&self, other: &&'b mut B) -> bool { PartialEq::ne(*self, *other) }
    +        fn ne(&self, other: &&mut B) -> bool { PartialEq::ne(*self, *other) }
         }
    ```
    
    [I didn't know this worked](https://internals.rust-lang.org/t/why-can-you-use-different-unconstrained-lifetimes-to-implement-traits/9544/2?u=scottmcm) until recently, but since defining methods contravariantly in their lifetimes this way has worked back to Rust 1.0, we might as well take advantage of combining it with IHLE.
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    25a31c4 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#59072 - RalfJung:miri-alloc-tests, r=kennytm

    we can now skip should_panic tests with the libtest harness
    Centril authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3e9fa5a View commit details
    Browse the repository at this point in the history