Fix segfaults in release build C-variadic fns #58985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@alexreg #58980 is actually very similar to that ICE I hit towards the end of the development of the original PR. I took the wrong route in fixing it which allows the segfault to happen. The segfault occurs because the "spoofed" |
dlrobertson
force-pushed
the
fix_58980
branch
2 times, most recently
from
6abae8c
to
1c47274
Compare
`va_start` and `va_end` must be called to initialize/cleanup the "spoofed" `VaList` in a Rust defined C-variadic function even if the `VaList` is not used.
|
@bors r+ p=1 fixes feature that is broken in release mode |
|
📌 Commit 1d72037 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
va_startandva_endmust be called to initialize/cleanup the"spoofed"
VaListin a Rust defined C-variadic function even ifthe
VaListis not used.r? @alexreg
Fixes: #58980