-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #58728
Merged
Merged
Rollup of 10 pull requests #58728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r=Centril Deny the `overflowing_literals` lint for all editions The `overflowing_literals` was made deny by default for the 2018 edition by rust-lang#54507, however I'm not aware of any reason it can't be made deny by default for the 2015 edition as well.
…on, r=oli-obk Reduce Miri Code Repetition like `(n << amt) >> amt` This Pull Request fixes a part of [rust-lang#49937](rust-lang#49937).
…ri-related, r=oli-obk Reduce a Code Repetition like `(n << amt) >> amt` Fixes a part of [rust-lang#49937](rust-lang#49937).
…lfJung Apply docs convention: Replace # Unsafety with # Safety in docs As used in RFC 1574: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md#using-markdown "Safety" is used many times more than "Unsafety" is within existing docs. @bors rollup r? @RalfJung
…ths, r=oli-obk librustc_codegen_llvm: #![deny(elided_lifetimes_in_paths)] As part of the Rust 2018 transition, remove `#![allow(elided_lifetimes_in_paths)]` from `librustc_codegen_llvm`. r? @oli-obk
…ths-librustc_codegen_ssa, r=oli-obk librustc_codegen_ssa: #![deny(elided_lifetimes_in_paths)] As part of the Rust 2018 transition, remove `#![allow(elided_lifetimes_in_paths)]` from `librustc_codegen_ssa`. r? @oli-obk
…ths-librustc_typeck, r=oli-obk librustc_typeck: deny(elided_lifetimes_in_paths) As part of the Rust 2018 transition, remove `#![allow(elided_lifetimes_in_paths)]` from `librustc_typeck`. r? @oli-obk
…ths-librustc, r=oli-obk librustc: deny(elided_lifetimes_in_paths) As part of the Rust 2018 transition, remove `#![allow(elided_lifetimes_in_paths)]` from `librustc`. r? @oli-obk
Test that binop subtyping in rustc_typeck fixes rust-lang#27949
…trap, r=Centril bootstrap: deny(rust_2018_idioms) As part of the Rust 2018 transition, apply `#![deny(rust_2018_idioms)]` to `bootstrap`. r? @Centril
@bors r+ p=10 |
📌 Commit d6de1e9 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Feb 25, 2019
bors
added a commit
that referenced
this pull request
Feb 25, 2019
Rollup of 10 pull requests Successful merges: - #55632 (Deny the `overflowing_literals` lint for all editions) - #58687 (Reduce Miri Code Repetition like `(n << amt) >> amt`) - #58690 (Reduce a Code Repetition like `(n << amt) >> amt`) - #58718 (Apply docs convention: Replace # Unsafety with # Safety in docs) - #58719 (librustc_codegen_llvm: #![deny(elided_lifetimes_in_paths)]) - #58720 (librustc_codegen_ssa: #![deny(elided_lifetimes_in_paths)]) - #58722 (librustc_typeck: deny(elided_lifetimes_in_paths)) - #58723 (librustc: deny(elided_lifetimes_in_paths)) - #58725 (Test that binop subtyping in rustc_typeck fixes #27949) - #58727 (bootstrap: deny(rust_2018_idioms)) Failed merges: r? @ghost
☀️ Test successful - checks-travis, status-appveyor |
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
overflowing_literals
lint for all editions #55632 (Deny theoverflowing_literals
lint for all editions)(n << amt) >> amt
#58687 (Reduce Miri Code Repetition like(n << amt) >> amt
)(n << amt) >> amt
#58690 (Reduce a Code Repetition like(n << amt) >> amt
)==
operator does not support subtyping #27949)Failed merges:
r? @ghost