Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition cargotest to Rust 2018 #58095

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Transition cargotest to Rust 2018 #58095

merged 1 commit into from
Feb 4, 2019

Conversation

h-michael
Copy link
Contributor

@h-michael h-michael commented Feb 3, 2019 •
edited
Loading

Only updating Cargo.toml

#58099

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019
@h-michael h-michael changed the title Use 2018 edition for cargotest Transition cargotest to Rust 2018 Feb 3, 2019
@Centril Centril mentioned this pull request Feb 3, 2019
Closed
78 tasks
@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

r? @Centril

Can you add #![deny(rust_2018_idioms)] to main.rs in this and the other transitioning PRs? (see #58099 for more details).

@rust-highfive rust-highfive assigned Centril and unassigned nikomatsakis Feb 3, 2019
@h-michael
Copy link
Contributor Author

Sure

@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2019

📌 Commit 9f34d4b has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2019
@bors
Copy link
Contributor

bors commented Feb 4, 2019

⌛ Testing commit 9f34d4b with merge 8ae730a...

bors added a commit that referenced this pull request Feb 4, 2019
@bors
Auto merge of #58095 - h-michael:cargotest-2018, r=Centril
8ae730a 
Transition cargotest to Rust 2018

Only updating Cargo.toml

#58099
@bors
Copy link
Contributor

bors commented Feb 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 8ae730a to master...

@bors bors merged commit 9f34d4b into rust-lang:master Feb 4, 2019
@h-michael h-michael deleted the cargotest-2018 branch February 4, 2019 07:50
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #58095!

Tested on commit 8ae730a.
Direct link to PR: #58095

🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#58095!
9cc86ae 
Tested on commit rust-lang/rust@8ae730a.
Direct link to PR: <rust-lang/rust#58095>

🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-michael @rust-highfive @Centril @bors @nikomatsakis