Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Rollup backports #57878

Merged
merged 4 commits into from
Jan 24, 2019
Merged

[beta] Rollup backports #57878

merged 4 commits into from
Jan 24, 2019

Conversation

pietroalbini
Copy link
Member

r? @ghost

pietroalbini and others added 4 commits January 24, 2019 17:08
@pietroalbini
make sure to accept all android licenses
f9b492f
@tromey @pietroalbini
Fix issue 57762
dc52f0f 
Issue 57762 points out a compiler crash when the compiler was built
using a stock LLVM 7.  LLVM 7 was released without a necessary fix for
a bug in the DWARF discriminant code.

This patch changes rustc to use the fallback mode on (non-Rust) LLVM 7.

Closes rust-lang#57762
@tromey @pietroalbini
Simplify the version check
676ade5 
Address the review comments by simplifying the version check to
just "< 8".
@michaelwoerister @pietroalbini
Fix typo bug in DepGraph::try_mark_green().
1652c7d
@pietroalbini
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Jan 24, 2019

📌 Commit 1652c7d has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 24, 2019
bors added a commit that referenced this pull request Jan 24, 2019
@bors
Auto merge of #57878 - pietroalbini:beta-backports, r=pietroalbini
635817b 
[beta] Rollup backports

* #57857: Fix Android CI failing to download SDKs
* #57840: Fix issue 57762
* #57698: Fix typo bug in DepGraph::try_mark_green().

r? @ghost
@bors
Copy link
Contributor

bors commented Jan 24, 2019

⌛ Testing commit 1652c7d with merge 635817b...

@bors
Copy link
Contributor

bors commented Jan 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 635817b to beta...

@bors bors merged commit 1652c7d into rust-lang:beta Jan 24, 2019
@pietroalbini pietroalbini deleted the beta-backports branch January 24, 2019 21:24
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pietroalbini @bors @Centril @tromey @michaelwoerister