Rollup of 5 pull requests #57599
Closed
Rollup of 5 pull requests #57599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat) on asymmetrically sized sets and extend unit tests slightly beyond that
Also, don't suggest comparing to zero for non-numeric expressions.
It shouldn't matter, but hey - better safe than sorry!
|
@bors r+ p=5 |
|
📌 Commit 9654f5ed0b18ab1644fd27636cfbe5ec996ac910 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 9654f5ed0b18ab1644fd27636cfbe5ec996ac910 with merge 7e8317110fba18e6dd06223682dcb555a5d9664c... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Clippy build fails due to #57442. |
|
cc @oli-obk if we're supposed to land this before the release now |
|
I think just removing #57442 would be the most sensible choice. There's no harm in letting it bake another 6 weeks |
Fix poor worst case performance of set intersection Specifically, intersection of asymmetrically sized sets when the large set is on the left. See also the [latest answer on stackoverflow](https://stackoverflow.com/questions/35439376/python-set-intersection-is-faster-then-rust-hashset-intersection). Also applied to the union member, where the effect is much less but still measurable. Formatted the changed code only, does not increase the error count reported by tidy check, and tried to adhere to the spirit of the unit tests.
Clean up and fix a bug in query plumbing r? @michaelwoerister
…bank provide suggestion for invalid boolean cast Also, don't suggest comparing to zero for non-numeric expressions.
Modify some parser diagnostics to continue evaluating beyond the parser Continue evaluating further errors after parser errors on: - trailing type argument attribute - lifetime in incorrect location - incorrect binary literal - missing `for` in `impl Trait for Foo` - type argument in `where` clause - incorrect float literal - incorrect `..` in pattern - associated types - incorrect discriminator value variant error and others. All of these were found by making `continue-parse-after-error` `true` by default to identify errors that would need few changes. There are now only a handful of errors that have any change with `continue-parse-after-error` enabled. These changes make it so `rust` _won't_ stop evaluation after finishing parsing, enabling type checking errors to be displayed on the existing code without having to fix the parse errors. Each commit has an individual diagnostic change with their corresponding tests. CC rust-lang#48724.
Querify local `plugin_registrar_fn` and `proc_macro_decls_static` Instead of calculating them as part of the `Session`, we do that in the query system. It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate. r? @nikomatsakis
…petrochenkov Unaccept `extern_in_paths` Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b. Closes rust-lang#55600 r? @petrochenkov
…ochenkov Recover from item trailing semicolon CC rust-lang/rfcs#2479 r? @petrochenkov
…r=alexcrichton Add a debug_assert to Vec::set_len Following the precedent of rust-lang#52972, which found llogiq/bytecount#42. (This may well make a test fail; let's see what Travis says.)
|
Removed in #57607. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ConstValue::ScalarPair#57442 (SimplifyConstValue::ScalarPair)plugin_registrar_fnandproc_macro_decls_static#57570 (Querify localplugin_registrar_fnandproc_macro_decls_static)Failed merges:
r? @ghost