Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unpretty option help message #57598

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Add missing unpretty option help message #57598

merged 1 commit into from
Jan 19, 2019

Conversation

h-michael
Copy link
Contributor

@h-michael h-michael commented Jan 14, 2019 •
edited
Loading

There are some missing help messages that is printed ructc -Zunpretty help and receiving invalid option.

related with #16419, #45721, #21085, #31916

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
oli-obk
oli-obk requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, lgtm otherwise

src/librustc/session/config.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
src/librustc/session/config.rs Outdated Show resolved Hide resolved
@h-michael
Copy link
Contributor Author

@oli-obk Thanks for your so quick review.
I've fixed it.

@rust-highfive

This comment has been minimized.

Sign in to view
@h-michael
Copy link
Contributor Author

@oli-obk Thanks for your review.
This is my first PR for rust.
So I don't know so match review process.
According to CONTRIBUTING.md, do I had you write @ bors +r?
Or is there anything which I should do?

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2019

According to CONTRIBUTING.md, do I had you write @ bors +r?

Once the PR is in a state where it can be merged, I will send it off to bors, yes. You don't need to worry about bors for now, I'll take care of that.

Or is there anything which I should do?

I left a few comments, you can click the Commit suggestion button to apply the changes (or you can manually change the code on your computer if you prefer).

@h-michael
Copy link
Contributor Author

I left a few comments, you can click the Commit suggestion button to apply the changes (or you can manually change the code on your computer if you prefer).

Oh, I'm sorry, I overlooked that one. 🙇

@h-michael
Copy link
Contributor Author

@oli-obk sorry, I fixed it.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2019

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 15, 2019

📌 Commit 260fb31 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019
@Centril
Rollup merge of rust-lang#57598 - h-michael:unpretty-help, r=oli-obk
c5dea61 
Add missing unpretty option help message

There are some missing help messages that is printed `ructc -Zunpretty help` and receiving invalid option.

related with rust-lang#16419, rust-lang#45721, rust-lang#21085, rust-lang#31916
@Centril Centril mentioned this pull request Jan 15, 2019
Closed
bors added a commit that referenced this pull request Jan 16, 2019
@bors
Auto merge of #57637 - Centril:rollup, r=Centril
eedef01 
Rollup of 6 pull requests

Successful merges:

 - #56884 (rustdoc: overhaul code block lexing errors)
 - #57065 (Optimize try_mark_green and eliminate the lock on dep node colors)
 - #57107 (Add a regression test for mutating a non-mut #[thread_local])
 - #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356))
 - #57551 (resolve: Add a test for issue #57539)
 - #57598 (Add missing unpretty option help message)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019
@Centril
Rollup merge of rust-lang#57598 - h-michael:unpretty-help, r=oli-obk
bce5688 
Add missing unpretty option help message

There are some missing help messages that is printed `ructc -Zunpretty help` and receiving invalid option.

related with rust-lang#16419, rust-lang#45721, rust-lang#21085, rust-lang#31916
@Centril Centril mentioned this pull request Jan 19, 2019
Merged
bors added a commit that referenced this pull request Jan 19, 2019
@bors
Auto merge of #57755 - Centril:rollup, r=Centril
9323499 
Rollup of 7 pull requests

Successful merges:

 - #57486 (Simplify `TokenStream` some more)
 - #57502 (make trait-aliases work across crates)
 - #57598 (Add missing unpretty option help message)
 - #57649 (privacy: Account for associated existential types)
 - #57659 (Fix release manifest generation)
 - #57699 (add applicability to remaining suggestions)
 - #57719 (Tweak `expand_node`)

Failed merges:

r? @ghost
@bors bors merged commit 260fb31 into rust-lang:master Jan 19, 2019
@h-michael h-michael deleted the unpretty-help branch January 20, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-michael @rust-highfive @oli-obk @bors