Add some unit tests to compiletest #56841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (currently) single unit test of the compiletest tool was never
executed on CI. At least I couldn't find any references of it in the
logs. This adds a test suite for compiletest so that our tester is
tested, too.
The compiletest tests can then also be executed with:
./x.py test src/tools/compiletest
There is a FIXME inside that function and I think the unit tests can be helpful to resolve it without breaking anything else.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 9637c27 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Dec 15, 2018
…ttests, r=oli-obk Add some unit tests to compiletest Based on rust-lang#56792, otherwise the tests won't be executed on CI. Just a small start, I would like to add more testing to compiletest in the future but that will require some refactoring first. cc rust-lang#47606
bors
added a commit
that referenced
this pull request
Dec 15, 2018
Rollup of 7 pull requests Successful merges: - #56677 (#[must_use] on traits in stdlib) - #56679 (overhaul external doc attribute diagnostics) - #56682 (Update the stdsimd submodule) - #56691 (fix install broken link) - #56710 (Always set the RDRAND and RDSEED features on SGX) - #56713 (Test capacity of ZST vector) - #56841 (Add some unit tests to compiletest) Failed merges: r? @ghost
phansch
added a commit
to phansch/compiletest-rs
that referenced
this pull request
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #56792, otherwise the tests won't be executed on CI.
Just a small start, I would like to add more testing to compiletest in the future but that will require some refactoring first.
cc #47606