Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy submodule #56643

Closed
wants to merge 1 commit into from
Closed

Update Clippy submodule #56643

wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Dec 9, 2018 •
edited
Loading

Should fix the toolstate.

Changes:

s/rustfmt-preview/rustfmt/
Swap if branches
Fix c_void false positive caused by libc refactoring
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
typo: emum -> enum
Fix format.
Add sysroot gettinh code to dogfood tests.
Add sysroot getting code to tests.
Don't try to determine sysroot. rustc_driver will use default value.
Fix suggestion for multiple derefs
Fix `clone_on_copy` not detecting derefs sometimes

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2018
@phansch
Copy link
Member Author

phansch commented Dec 9, 2018

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned nikomatsakis Dec 9, 2018
@nikic
Copy link
Contributor

nikic commented Dec 9, 2018

Closing in favor of #56631, which is also updates clippy :)

@nikic nikic closed this Dec 9, 2018
@phansch
Copy link
Member Author

phansch commented Dec 9, 2018

woops, did a search and didn't see it, thanks!

@phansch phansch deleted the update_clippy_submodule branch December 9, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phansch @rust-highfive @nikic @nikomatsakis @oli-obk