Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable release 1.30 #55315

Merged
merged 6 commits into from
Oct 24, 2018
Merged

Stable release 1.30 #55315

merged 6 commits into from
Oct 24, 2018

Conversation

pietroalbini
Copy link
Member

This PR also reverts the stabilization of non_modrs_mods and the 2018 edition.

r? @Mark-Simulacrum
cc @rust-lang/release

carols10cents and others added 3 commits October 24, 2018 15:10
@carols10cents @pietroalbini
Do some copy editing on the release notes
fa20daa 
I was reading through the release notes to find something and noticed
some small grammatical and consistency issues.
@pietroalbini
Destabilize feature non_modrs_mods
8b5dc95 
This reverts commit 7f6b608.
@pietroalbini
Destabilize 2018 edition
b56d514 
This reverts commit 4d1ec81.
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit 5b4af4ac45a9f4b3e5bd5a211f6a4d20d99dfb84 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2018
@Mark-Simulacrum
Copy link
Member

@bors r-

We'll need a cargo update as well -- cargo new defaults to 2018

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit 028e6fc7db3801c8dd39507cbad2acad6c6773e7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2018
@bors
Copy link
Contributor

bors commented Oct 24, 2018

⌛ Testing commit 028e6fc7db3801c8dd39507cbad2acad6c6773e7 with merge 2a2108ae3b55b3919b9c8486147eb9d01ff5d2e8...

@bors
Copy link
Contributor

bors commented Oct 24, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2018
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit 4a0c8d1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2018
@bors
Copy link
Contributor

bors commented Oct 24, 2018

⌛ Testing commit 4a0c8d1 with merge da5f414...

bors added a commit that referenced this pull request Oct 24, 2018
@bors
Auto merge of #55315 - pietroalbini:release-1.30.0, r=Mark-Simulacrum
da5f414 
Stable release 1.30

This PR also reverts the stabilization of `non_modrs_mods` and the 2018 edition.

r? @Mark-Simulacrum
cc @rust-lang/release
@petrochenkov petrochenkov mentioned this pull request Oct 24, 2018
Merged
@bors bors mentioned this pull request Oct 24, 2018
Merged
@bors
Copy link
Contributor

bors commented Oct 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing da5f414 to stable...

@bors bors merged commit 4a0c8d1 into rust-lang:stable Oct 24, 2018
@pietroalbini pietroalbini deleted the release-1.30.0 branch October 25, 2018 07:44
@ehuss ehuss mentioned this pull request Oct 25, 2018
Merged
bors added a commit that referenced this pull request Oct 26, 2018
@bors
Auto merge of #55362 - ehuss:releases-cargo-new-edition, r=Mark-Simul…
82239b0 
…acrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (#55315, rust-lang/cargo#6216).
Apologies for not catching this.
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this pull request Nov 7, 2018
@bors @Mark-Simulacrum
Auto merge of rust-lang#55362 - ehuss:releases-cargo-new-edition, r=M…
d6cd7bb 
…ark-Simulacrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (rust-lang#55315, rust-lang/cargo#6216).
Apologies for not catching this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @rust-highfive @Mark-Simulacrum @bors @kennytm @carols10cents