-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support type annot in constants, casts #55152
support type annot in constants, casts #55152
Conversation
8920925
to
bc1f493
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bc1f493
to
35e2f72
Compare
OK, works now. |
Well, famous last words. =) |
@bors r+ |
📌 Commit 35e2f72603f25c64640bc3fd52c39f12572438ac has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
a464340
to
d99fb09
Compare
OK so this had some fallout on diagnostics -- I think because we are proving some things multiple times? We can probably find a way to suppress the duplicates. The constant errors I am less sure how to fix (cc @oli-obk @RalfJung). The underlying problem is that with a cast like
Perhaps the best fix would be to do this ascription less often, actually. For example, if there are no regions in type we are casting to, we don't have to preserve the user-supplied type (NLL doesn't care). |
This comment has been minimized.
This comment has been minimized.
a030f36
to
ba124c3
Compare
OK, I pushed a workaround and fixed some other bugs -- there is one FIXME I am still pondering, about what we prove WF for, but this PR is strictly better than the status quo and (I think) probably fine as is. The remaining potential bug (that I know of) probably exists without NLL and is really about normalization and hence more the domain of #54940. |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #55134) made this pull request unmergeable. Please resolve the merge conflicts. |
Which errors are you referring to?
What is the type of |
d6f967b
to
9a7bb0e
Compare
@bors r=pnkfelix |
📌 Commit 9a7bb0e has been approved by |
⌛ Testing commit 9a7bb0e with merge b0a8a62621e2de5dcd45cace048ea63cde950c56... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
cc @rust-lang/infra — looks like a network error or something — am I supposed to catalog this in some way? |
☀️ Test successful - status-appveyor, status-travis |
@nikomatsakis Yes it's a network error and we've recorded this down. There was an outage in S3 in the US-WEST-1 region around 2018-10-19 17~18 UTC causing this error. Error in deployment is basically always spurious and unfortunately something out of our control. |
@kennytm great thanks — I mostly want to know if there are steps I should be taking beyond |
Fixes #54571
Fixes #54332
Fixes #55183
r? @pnkfelix