rustdoc: don't prefer dynamic linking in doc tests #54939
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
…c-tests, r=<try> [WIP] rustdoc: don't prefer dynamic linking in doc tests This is an attempt to address the regression in #54478 This may be a case where the cure is worse than the disease, at least in the short term... cc @alexcrichton
|
Ok I finally got around to my local machine, and it looks like this passes |
|
oh darn I clearly should have left a blank line there! 😆 |
|
@craterbot run name=rustdoc-test-static-cling start=master#0e07c4281c343e9e15a0a8fca79538ad1a8eb513 end=try#40d4795669493f1965de7c44029c69552134fe1f mode=build-and-test |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
Well the good news is that this fixed 10 crates. The bad news is that it regressed 23000 crates. @pietroalbini random selections of error logs look sort of confusing, did this run have errors in the middle perhaps? |
|
Yes, I believe the conclusion was that the run itself errored (rather than this PR causing most of the failures). @craterbot run name=rustdoc-test-static-cling-1 start=master#0e07c4281c343e9e15a0a8fca79538ad1a8eb513 end=try#40d4795669493f1965de7c44029c69552134fe1f mode=build-and-test |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
https://crater-reports.s3.amazonaws.com/rustdoc-test-static-cling-1/try%2340d4795669493f1965de7c44029c69552134fe1f/reg/docmatic-0.1.2/log.txt Haven't tried to reproduce locally but those are the failures that look possibly non-spurious. The wrong crate/mismatched types is the only one I'm super concerned with -- but since it's one case out of ~80k crates tested it seems unlikely that it's actually a problem. As such, presuming we're not expecting a serious performance regression here, I think this is ready to go |
pnkfelix
changed the title
pnkfelix
added
T-rustdoc
|
(I just want someone from https://www.rust-lang.org/en-US/team.html#Rustdoc-team to give a 👍 here before we go and land it...) |
pnkfelix
added
the
beta-nominated
Mark-Simulacrum
added
the
beta-accepted
|
Based on @alexcrichton's reasoning in #54478 (comment), this gets a +1 from me. It would be nice to know why it was set like that in the first place, but since it was set like that for as long as rustdoc has had doctests, i doubt we'll know for sure. |
|
@bors r=QuietMisdreavus |
|
📌 Commit cbca688 has been approved by |
bors
added
S-waiting-on-bors
…c-tests, r=QuietMisdreavus rustdoc: don't prefer dynamic linking in doc tests This is an attempt to address the regression in #54478 This may be a case where the cure is worse than the disease, at least in the short term... cc @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
removed
the
beta-nominated
[beta] Rollup backports Merged and approved: * #54300: Updated RELEASES.md for 1.30.0 * #54939: rustdoc: don't prefer dynamic linking in doc tests * #54671: resolve: Scale back hard-coded extern prelude additions on 2015 edition * #55102: resolve: Do not skip extern prelude during speculative resolution r? @ghost
rustdoc: Don't modify library path for doctests It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic` (since #54939). r? @QuietMisdreavus
This is an attempt to address the regression in #54478
This may be a case where the cure is worse than the disease, at least in the short term...
cc @alexcrichton