Stabilize the Option::replace method
#54904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Centril |
Centril
reviewed
Oct 8, 2018
src/libcore/option.rs
Outdated
| @@ -880,7 +878,7 @@ impl<T> Option<T> { | |||
| /// assert_eq!(old, None); | |||
| /// ``` | |||
| #[inline] | |||
| #[unstable(feature = "option_replace", issue = "51998")] | |||
| #[stable(feature = "option_replace", since = "1.30.0")] | |||
There was a problem hiding this comment.
1.30.0 seems unlikely? See https://forge.rust-lang.org/index.html for dates.
There was a problem hiding this comment.
It is unlikely to be merged for Fri Oct 26 2018 ? You prefer 1.31.0 ?
There was a problem hiding this comment.
It has to go into beta first ;) i.e. 1.31.0 goes into beta on 2018-10-26.
There was a problem hiding this comment.
Ok I will change to 1.31.0 so but how do you know the 1.31.0 beta is set to this date ?
There was a problem hiding this comment.
Ho ! It enters beta when the previous version enter stable ? ok ! :)
|
r? @Kimundi (Already fcp merged + completed in tracking issue.) |
|
Do I squash when done ? |
|
@Kerollmops if you wish; but I think it's fine not to also. |
Centril
added
the
relnotes
|
@bors r=Centril |
|
📌 Commit c232ea1 has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 9, 2018
…, r=Centril Stabilize the `Option::replace` method This PR stabilize the `Option::replace` method propose in rust-lang#51998.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 10, 2018
…, r=Centril Stabilize the `Option::replace` method This PR stabilize the `Option::replace` method propose in rust-lang#51998.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 10, 2018
…, r=Centril Fixes rust-lang#47311. r? @nrc
bors
added a commit
that referenced
this pull request
Oct 11, 2018
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
bors
added a commit
that referenced
this pull request
Oct 11, 2018
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
Centril
added
the
T-libs-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilize the
Option::replacemethod propose in #51998.