Stabilize pattern_parentheses feature #54497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
5 tasks
nikomatsakis
approved these changes
Sep 24, 2018
| BitXor | BitAnd | BitOr | Shl | Shr => | ||
| false, | ||
| Eq | Lt | Le | Ne | Gt | Ge => true, | ||
| And | Or | Add | Sub | Mul | Div | Rem | BitXor | BitAnd | BitOr | Shl | Shr => false, |
There was a problem hiding this comment.
Nit: It's not super important, but it's always nice to factor out rustfmt runs into their own commit (it'd be nice if we just rustfmt'd everything ... but that's neither here nor there)
There was a problem hiding this comment.
whoops -- yeah this was a mistake on my part -- i was only going to make this change with the typo: de5f6ee#diff-0de6e63ecfba5c83fb06c9e981f292a6R636
and not rustfmt this file but i guess it slipped through.
|
Looks good! |
|
@bors r+ |
|
📌 Commit a381868 has been approved by |
bors
added
S-waiting-on-bors
Centril
added
the
relnotes
bors
added a commit
that referenced
this pull request
Sep 26, 2018
…ikomatsakis Stabilize pattern_parentheses feature Addresses #51087 . Stabilizes the previously unstable feature `pattern_parentheses` which enables the use of `()` in match patterns.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #51087 .
Stabilizes the previously unstable feature
pattern_parentheseswhich enables the use of()in match patterns.