Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rls to 32d457717ce37babef199fe4984b1e20d4e108d4 #54489

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 22, 2018

I patched rls to use the rustc_tools_utils supplied by the clippy submodule to get around the tidy warning.

Should fix rls and toolstate.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
tidy check
[00:05:19] * 555 error codes
[00:05:19] * highest error code: E0712
[00:05:20] * 231 features
[00:05:21] invalid source: "git+https://github.com/rust-lang-nursery/rust-clippy?rev=125907ad08853b92d35e86aecebcf0f784f348d5#125907ad08853b92d35e86aecebcf0f784f348d5"
[00:05:21] some tidy checks failed
[00:05:21] 
[00:05:21] 
[00:05:21] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:21] 
[00:05:21] 
[00:05:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:21] Build completed unsuccessfully in 0:00:50
[00:05:21] Build completed unsuccessfully in 0:00:50
[00:05:21] Makefile:79: recipe for target 'tidy' failed
[00:05:21] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:24ba0670
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:15924f72:start=1537654324288822613,finish=1537654324292900934,duration=4078321
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:337a2428
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2b18f0fb
travis_time:start:2b18f0fb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0e5bee26
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Sep 22, 2018

[00:05:21] invalid source: "git+https://github.com/rust-lang-nursery/rust-clippy?rev=125907ad08853b92d35e86aecebcf0f784f348d5#125907ad08853b92d35e86aecebcf0f784f348d5"
what is this trying to tell me?

edit: should be fixed

@kennytm
Copy link
Member

kennytm commented Sep 24, 2018

@bors r+ p=3

@bors
Copy link
Contributor

bors commented Sep 24, 2018

📌 Commit 500352f has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2018
@bors
Copy link
Contributor

bors commented Sep 24, 2018

⌛ Testing commit 500352f with merge 5ad5aca...

bors added a commit that referenced this pull request Sep 24, 2018
update rls to 32d457717ce37babef199fe4984b1e20d4e108d4

I patched rls to use the `rustc_tools_utils` supplied by the clippy submodule to get around the tidy warning.

Should fix rls and toolstate.
@bors
Copy link
Contributor

bors commented Sep 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 5ad5aca to master...

@bors bors merged commit 500352f into rust-lang:master Sep 24, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #54489!

Tested on commit 5ad5aca.
Direct link to PR: #54489

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 24, 2018
Tested on commit rust-lang/rust@5ad5aca.
Direct link to PR: <rust-lang/rust#54489>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants