[beta] Stabilize crate_in_paths, extern_absolute_paths and extern_prelude on all editions. #54404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ p=4 |
|
📌 Commit 7d2b68798d7c026ac6eb637319d295aab89dba66 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: p=5 |
eddyb
force-pushed
the
oopsie-daisy-stabilize-beta
branch
from
7d2b687
to
4774691
Compare
|
@bors r=alexcrichton |
|
📌 Commit 4774691e63764fc02bc1967a490f5691c18837f9 has been approved by |
This comment has been minimized.
This comment has been minimized.
eddyb
force-pushed
the
oopsie-daisy-stabilize-beta
branch
from
4774691
to
d12881f
Compare
|
@bors r=alexcrichton |
|
📌 Commit d12881f45ce2b98abcf17335ad6b1e91514b04ee has been approved by |
|
⌛ Testing commit d12881f45ce2b98abcf17335ad6b1e91514b04ee with merge 99c4deba013ff01d873ffee8947cc4bc7c1a222f... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@alexcrichton I'm not sure what's happening here - is this Cargo's test suite? Does it needs to be fixed on Cargo's end? |
kennytm
added
S-waiting-on-author
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Sep 21, 2018
[beta] Remove `fix::local_paths_no_fix`, as `crate_in_paths` is getting stabilized. Beta backport of #6068. Needed for rust-lang/rust#54404 (blocking RC1). r? @alexcrichton
eddyb
force-pushed
the
oopsie-daisy-stabilize-beta
branch
from
d12881f
to
a9deb45
Compare
eddyb
force-pushed
the
oopsie-daisy-stabilize-beta
branch
from
a9deb45
to
d157ef1
Compare
|
@bors r=alexcrichton |
|
📌 Commit d157ef1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 21, 2018
[beta] Stabilize crate_in_paths, extern_absolute_paths and extern_prelude on all editions. Beta backport of #54403. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 28, 2018
bors
added a commit
that referenced
this pull request
Oct 17, 2018
resolve: Scale back hard-coded extern prelude additions on 2015 edition #54404 stabilized `feature(extern_prelude)` on 2015 edition, including the hard-coded parts not passed with `--extern`. First of all, I'd want to confirm that this is intended stabilization, rather than a part of the "extended beta" scheme that's going to be reverted before releasing stable. (EDIT: to clarify - this is a question, I'm \*asking\* for confirmation, rather than give it.) Second, on 2015 edition extern prelude is not so fundamentally tied to imports and is a mere convenience, so this PR scales them back to the uncontroversial subset. The "uncontroversial subset" means that if libcore is injected it brings `core` into prelude, if libstd is injected it brings `std` and `core` into prelude. On 2015 edition this can be implemented through the library prelude (rather than hard-coding in the compiler) right now, I'll do it in a follow-up PR. UPDATE: The change is done for both 2015 and 2018 editions now as discussed below. Closes #53166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backport of #54403.
r? @alexcrichton