#53576 Renaming TyAnon -> TyOpaque #53705

ms2300 · 2018-08-25T20:31:12Z

rust-highfive · 2018-08-25T20:31:22Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ms2300 · 2018-08-25T20:32:36Z

r? @eddyb

varkor

This looks great to me! (@eddyb might remember if there's anywhere else that needs changing, so I'll leave the final approval to them.)

ms2300 · 2018-08-27T20:53:29Z

All good? Should I be doing anything else?

bors · 2018-08-28T09:01:31Z

☔ The latest upstream changes (presumably #53616) made this pull request unmergeable. Please resolve the merge conflicts.

ms2300 · 2018-08-28T22:25:29Z

How do I resolve these conflicts without merging from upstream?

Edit: Just rebased and it should work

TimNN · 2018-09-04T18:17:42Z

Ping from triage @eddyb / @rust-lang/compiler: This PR requires your review.

varkor · 2018-09-04T22:50:41Z

All good? Should I be doing anything else?

Sorry, I meant to get back to this, but somehow forgot! It all looks correct to me — just one last thing: could you squash the related changes together? (Either one commit for everything, or one for code changes and one for test changes.)

I'll approve after that (and @eddyb can add any additional comments afterwards if I've forgotten anything else)! Thanks!

ms2300 · 2018-09-05T19:02:46Z

I squashed into two commits, thanks for the update!

rust-highfive · 2018-09-05T19:18:25Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:13:42]    Compiling rustc_metadata_utils v0.0.0 (file:///checkout/src/librustc_metadata_utils)
[00:13:42]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:13:42]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:13:43]    Compiling rustc_allocator v0.0.0 (file:///checkout/src/librustc_allocator)
[00:13:44] error[E0531]: cannot find tuple struct/variant `Anon` in module `ty`
[00:13:44]    --> librustc_mir/transform/qualify_min_const_fn.rs:103:17
[00:13:44]     |
[00:13:44] 103 |             ty::Anon(..) => return Err((span, "`impl Trait` in const fn is unstable".into())),
[00:13:44] help: possible candidate is found in another module, you can import it into scope
[00:13:44]     |
[00:13:44]     |
[00:13:44] 1   | use rustc::dep_graph::OpenTask::Anon;
[00:13:44] 
[00:13:55] error: aborting due to previous error
[00:13:55] 
[00:13:55] For more information about this error, try `rustc --explain E0531`.
[00:13:55] For more information about this error, try `rustc --explain E0531`.
[00:13:55] error: Could not compile `rustc_mir`.
[00:13:55] 
[00:13:55] Caused by:
[00:13:55]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=9389ef21a7981207 -C extra-filename=-9389ef21a7981207 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-93ff3b002b18b7ed.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-5a39798fe03e47f4.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-8246be02936c9b1b.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-0a515e87c8afea9e.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-45ae4394366d07fd.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-c55d6c95192e4906.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-87ec950697a15ed0.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-218f3033f29f5493.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-09c0f3a89ad0d6b5.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-96aac12abd62414d.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-05301c67193a930e.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-f4ac364f854372fe.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-4a08b81d2b6640c1.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-8d84add221c0f710.rlib --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsmallvec-cb741677cd0e0351.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-0651ffc5a9129db1.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-47b99ffec2efbd05.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-ee16f6821aef40e9/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-52504d5ed57fefc2/out` (exit code: 1)
[00:15:05] error: build failed
[00:15:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:15:05] expected success, got: exit code: 101
[00:15:05] expected success, got: exit code: 101
[00:15:05] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1155:9
[00:15:05] travis_fold:end:stage0-rustc

[00:15:05] travis_time:end:stage0-rustc:start=1536174534184896379,finish=1536175100528248583,duration=566343352204


[00:15:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:15:05] Build completed unsuccessfully in 0:10:25
[00:15:05] Makefile:28: recipe for target 'all' failed
[00:15:05] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04adc0a7
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
20384 ./.git/modules/src/liblibc/objects
20376 ./.git/modules/src/liblibc/objects/pack
20032 ./src/tools/lldb/source
travis_time:end:0b19f61c:start=1536175100968716617,finish=1536175101365119134,duration=396402517
travis_fold:end:after_faile/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:039b4a68
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-09-05T20:56:57Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:01:57] extracting /checkout/obj/build/cache/2018-08-01/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:57] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:01:57] 
[00:01:57] Caused by:
[00:01:57]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:01:57] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:57] make: *** [prepare] Error 1
[00:01:57] Makefile:81: recipe for target 'prepare' failed
[00:01:58] Command failed. Attempt 2/5:
[00:01:58] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:01:58] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:01:58] 
[00:01:58] Caused by:
[00:01:58]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:01:58] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:58] Makefile:81: recipe for target 'prepare' failed
[00:01:58] make: *** [prepare] Error 1
[00:02:00] Command failed. Attempt 3/5:
[00:02:00] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:00] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:00] 
[00:02:00] Caused by:
[00:02:00]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:02:00] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:00] Makefile:81: recipe for target 'prepare' failed
[00:02:00] make: *** [prepare] Error 1
[00:02:03] Command failed. Attempt 4/5:
[00:02:03] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:03] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:03] 
[00:02:03] Caused by:
[00:02:03]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:02:03] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:03] Makefile:81: recipe for target 'prepare' failed
[00:02:03] make: *** [prepare] Error 1
[00:02:07] Command failed. Attempt 5/5:
[00:02:07] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:07] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[00:02:07] 
[00:02:07] Caused by:
[00:02:07]   patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
[00:02:07] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:07] make: *** [prepare] Error 1
[00:02:07] Makefile:81: recipe for target 'prepare' failed
[00:02:07] The command has failed after 5 attempts.
travis_time:end:16c50f06:start=1536180867770422072,finish=1536181001567828560,duration=133797406488
---
travis_time:end:21f542c9:start=1536181002050515312,finish=1536181002060906144,duration=10390832
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:132639ba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:050be3a2
travis_time:start:050be3a2
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0ef40fd2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2018-09-05T23:04:01Z

Thanks @ms2300! Sorry for the wait!

@bors r+

bors · 2018-09-06T05:00:21Z

💔 Test failed - status-travis

rust-highfive · 2018-09-06T05:00:23Z

The job wasm32-unknown of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:25:08] [ 23%] Building CXX object Common/CMakeFiles/lldCommon.dir/Threads.cpp.o
[00:25:08] [ 24%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/LayoutPass.cpp.o
[00:25:08] [ 25%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachOLinkingContext.cpp.o
[00:25:08] [ 26%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
[00:25:08] /checkout/src/tools/lld/Common/ErrorHandler.cpp: In function 'void lld::exitLld(int)':
[00:25:08] /checkout/src/tools/lld/Common/ErrorHandler.cpp:52:34: error: 'class llvm::FileOutputBuffer' has no member named 'discard'
[00:25:08]      errorHandler().OutputBuffer->discard();
[00:25:08]                                   ^
[00:25:08] Common/CMakeFiles/lldCommon.dir/build.make:86: recipe for target 'Common/CMakeFiles/lldCommon.dir/ErrorHandler.cpp.o' failed
[00:25:08] CMakeFiles/Makefile2:117: recipe for target 'Common/CMakeFiles/lldCommon.dir/all' failed
[00:25:08] make[2]: *** [Common/CMakeFiles/lldCommon.dir/ErrorHandler.cpp.o] Error 1
[00:25:08] make[1]: *** [Common/CMakeFiles/lldCommon.dir/all] Error 2
[00:25:08] make[1]: *** Waiting for unfinished jobs....
[00:25:09] [ 27%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileFromAtoms.cpp.o
[00:25:09] [ 28%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileToAtoms.cpp.o
[00:25:09] [ 29%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileYAML.cpp.o
[00:25:09] [ 30%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ObjCPass.cpp.o
[00:25:09] [ 30%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ObjCPass.cpp.o
[00:25:09] [ 30%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ShimPass.cpp.o
[00:25:09] [ 31%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/StubsPass.cpp.o
[00:25:09] [ 32%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/TLVPass.cpp.o
[00:25:09] [ 33%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/WriterMachO.cpp.o
[00:25:10] [ 34%] Linking CXX static library ../../liblldMachO.a
[00:25:10] [ 34%] Built target lldMachO
[00:25:10] Makefile:127: recipe for target 'all' failed
[00:25:10] make: *** [all] Error 2
[00:25:10] command did not execute successfully, got: exit code: 2
[00:25:10] 
[00:25:10] 
[00:25:10] build script failed, must exit now', /cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.33/src/lib.rs:773:5
[00:25:10]  finished in 7.608
[00:25:10] travis_fold:end:lld

[00:25:10] travis_time:end:lld:start=1536209962734215211,finish=1536209970343066811,duration=7608851600
---
travis_time:end:073dd234:start=1536209971300956270,finish=1536209971310682768,duration=9726498
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:030cda60
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01745760
travis_time:start:01745760
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:392d8e68
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ms2300 · 2018-09-06T06:38:37Z

Does anyone know what this error is referencing?

Edit: I thought I had ran all of the normal test commands and they passed (?)

oli-obk · 2018-09-06T07:24:49Z

@bors retry network error

bors · 2018-09-06T09:06:36Z

⌛ Testing commit 5648d07 with merge 3afde98...

#53576 Renaming TyAnon -> TyOpaque Fixes #53576

bors · 2018-09-06T09:32:19Z

💔 Test failed - status-travis

rust-highfive · 2018-09-06T09:32:21Z

The job wasm32-unknown of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:22:36] [ 24%] Built target COFFOptionsTableGen
[00:22:36] [ 25%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/LayoutPass.cpp.o
[00:22:36] [ 26%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachOLinkingContext.cpp.o
[00:22:36] [ 27%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
[00:22:37] /checkout/src/tools/lld/Common/ErrorHandler.cpp: In function 'void lld::exitLld(int)':
[00:22:37] /checkout/src/tools/lld/Common/ErrorHandler.cpp:52:34: error: 'class llvm::FileOutputBuffer' has no member named 'discard'
[00:22:37]      errorHandler().OutputBuffer->discard();
[00:22:37]                                   ^
[00:22:37] Common/CMakeFiles/lldCommon.dir/build.make:86: recipe for target 'Common/CMakeFiles/lldCommon.dir/ErrorHandler.cpp.o' failed
[00:22:37] make[2]: *** [Common/CMakeFiles/lldCommon.dir/ErrorHandler.cpp.o] Error 1
[00:22:37] CMakeFiles/Makefile2:117: recipe for target 'Common/CMakeFiles/lldCommon.dir/all' failed
[00:22:37] make[1]: *** [Common/CMakeFiles/lldCommon.dir/all] Error 2
[00:22:37] make[1]: *** Waiting for unfinished jobs....
[00:22:37] [ 28%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileFromAtoms.cpp.o
[00:22:37] [ 29%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileToAtoms.cpp.o
[00:22:37] [ 30%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileYAML.cpp.o
[00:22:37] [ 31%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ObjCPass.cpp.o
[00:22:37] [ 31%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ObjCPass.cpp.o
[00:22:37] [ 31%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/ShimPass.cpp.o
[00:22:37] [ 32%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/StubsPass.cpp.o
[00:22:37] [ 33%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/TLVPass.cpp.o
[00:22:37] [ 34%] Building CXX object lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/WriterMachO.cpp.o
[00:22:38] [ 35%] Linking CXX static library ../../liblldMachO.a
[00:22:38] [ 35%] Built target lldMachO
[00:22:38] make: *** [all] Error 2
[00:22:38] Makefile:127: recipe for target 'all' failed
[00:22:38] command did not execute successfully, got: exit code: 2
[00:22:38] 
[00:22:38] 
[00:22:38] build script failed, must exit now', /cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.33/src/lib.rs:773:5
[00:22:38]  finished in 6.736
[00:22:38] travis_fold:end:lld

[00:22:38] travis_time:end:lld:start=1536226291424387231,finish=1536226298160684210,duration=6736296979
---
travis_time:end:1cdcc988:start=1536226299013596953,finish=1536226299020133251,duration=6536298
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:23779fb4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00ab93ff
travis_time:start:00ab93ff
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02e07ec0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-09-06T10:27:27Z

You updated the llvm submodule. Please revert that (That's also the source of the failure)

ms2300 · 2018-09-06T17:46:25Z

Yeah for some reason I updated a lot of the submodules somewhere in the rebasing process and reverted all but that one. My bad it should work now

oli-obk · 2018-09-06T19:26:45Z

@bors r+

bors · 2018-09-06T19:26:46Z

📌 Commit f4d4faa has been approved by oli-obk

rust-lang#53576 Renaming TyAnon -> TyOpaque Fixes rust-lang#53576

bors · 2018-09-08T14:16:45Z

⌛ Testing commit f4d4faa with merge b24330f...

#53576 Renaming TyAnon -> TyOpaque Fixes #53576

bors · 2018-09-08T16:36:24Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing b24330f to master...

rust-highfive assigned pnkfelix Aug 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2018

rust-highfive assigned eddyb and unassigned pnkfelix Aug 25, 2018

ms2300 mentioned this pull request Aug 25, 2018

Rename "anonymized types" internally (TyAnon & friends) to "opaque types" (TyOpaque etc.). #53576

Closed

varkor approved these changes Aug 25, 2018

View reviewed changes

ms2300 force-pushed the tmp branch from fc8c0af to f5a9392 Compare August 28, 2018 22:24

ms2300 force-pushed the tmp branch from f5a9392 to 686dc4b Compare August 28, 2018 22:38

This comment has been minimized.

Sign in to view

ms2300 force-pushed the tmp branch from 686dc4b to 1e14c07 Compare September 5, 2018 18:57

Changing TyAnon -> TyOpaque and relevant functions

6c14360

ms2300 force-pushed the tmp branch from 1e14c07 to 728f695 Compare September 5, 2018 19:01

ms2300 force-pushed the tmp branch from 728f695 to 9d8e7b4 Compare September 5, 2018 19:23

ms2300 force-pushed the tmp branch from e1a33f2 to 5648d07 Compare September 5, 2018 21:00

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018

bors added a commit that referenced this pull request Sep 6, 2018

Auto merge of #53705 - ms2300:tmp, r=varkor

3afde98

#53576 Renaming TyAnon -> TyOpaque Fixes #53576

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2018

Fixing tests from anon -> opaque

f4d4faa

ms2300 force-pushed the tmp branch from 5648d07 to f4d4faa Compare September 6, 2018 17:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Sep 7, 2018

Rollup merge of rust-lang#53705 - ms2300:tmp, r=oli-obk

d3b9ec5

rust-lang#53576 Renaming TyAnon -> TyOpaque Fixes rust-lang#53576

kennytm mentioned this pull request Sep 7, 2018

Rollup of 9 pull requests #54036

Closed

bors added a commit that referenced this pull request Sep 8, 2018

Auto merge of #53705 - ms2300:tmp, r=oli-obk

b24330f

#53576 Renaming TyAnon -> TyOpaque Fixes #53576

bors merged commit f4d4faa into rust-lang:master Sep 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#53576 Renaming TyAnon -> TyOpaque #53705

#53576 Renaming TyAnon -> TyOpaque #53705

ms2300 commented Aug 25, 2018

rust-highfive commented Aug 25, 2018

ms2300 commented Aug 25, 2018

varkor left a comment

ms2300 commented Aug 27, 2018

bors commented Aug 28, 2018

ms2300 commented Aug 28, 2018 •

edited

Loading

TimNN commented Sep 4, 2018

varkor commented Sep 4, 2018 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ms2300 commented Sep 5, 2018

rust-highfive commented Sep 5, 2018

rust-highfive commented Sep 5, 2018

varkor commented Sep 5, 2018

bors commented Sep 6, 2018

rust-highfive commented Sep 6, 2018

ms2300 commented Sep 6, 2018 •

edited

Loading

oli-obk commented Sep 6, 2018

bors commented Sep 6, 2018

bors commented Sep 6, 2018

rust-highfive commented Sep 6, 2018

oli-obk commented Sep 6, 2018

ms2300 commented Sep 6, 2018

oli-obk commented Sep 6, 2018

bors commented Sep 6, 2018

bors commented Sep 8, 2018

bors commented Sep 8, 2018

#53576 Renaming TyAnon -> TyOpaque #53705

#53576 Renaming TyAnon -> TyOpaque #53705

Conversation

ms2300 commented Aug 25, 2018

rust-highfive commented Aug 25, 2018

ms2300 commented Aug 25, 2018

varkor left a comment

Choose a reason for hiding this comment

ms2300 commented Aug 27, 2018

bors commented Aug 28, 2018

ms2300 commented Aug 28, 2018 • edited Loading

TimNN commented Sep 4, 2018

varkor commented Sep 4, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

ms2300 commented Sep 5, 2018

rust-highfive commented Sep 5, 2018

rust-highfive commented Sep 5, 2018

varkor commented Sep 5, 2018

bors commented Sep 6, 2018

rust-highfive commented Sep 6, 2018

ms2300 commented Sep 6, 2018 • edited Loading

oli-obk commented Sep 6, 2018

bors commented Sep 6, 2018

bors commented Sep 6, 2018

rust-highfive commented Sep 6, 2018

oli-obk commented Sep 6, 2018

ms2300 commented Sep 6, 2018

oli-obk commented Sep 6, 2018

bors commented Sep 6, 2018

bors commented Sep 8, 2018

bors commented Sep 8, 2018

ms2300 commented Aug 28, 2018 •

edited

Loading

varkor commented Sep 4, 2018 •

edited

Loading

ms2300 commented Sep 6, 2018 •

edited

Loading