Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement try block expressions #52602

Merged
merged 10 commits into from
Aug 23, 2018
Merged

Implement try block expressions #52602

merged 10 commits into from
Aug 23, 2018

Commits on Aug 19, 2018

  1. Rename Catch variants to TryBlock 

    (Not `Try` since `QuestionMark` is using that.)
    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    f2445fb View commit details
    Browse the repository at this point in the history

  2. Add try to syntax_pos as an edition-2018-only keyword

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    1c90609 View commit details
    Browse the repository at this point in the history

  3. Parse try blocks with the try keyword instead of do catch placeholder

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    9e64ce1 View commit details
    Browse the repository at this point in the history

  4. Fix the unstable book 

    I ignored the code block as I didn't see a way to run the doctest in 2018 -- I noticed the edition guide is also not testing its 2018 code snippits.
    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    ef19886 View commit details
    Browse the repository at this point in the history

  5. Put try in the reserved list, not the in-use list

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    91967a8 View commit details
    Browse the repository at this point in the history

  6. Suggest try if someone uses do catch

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    817efc2 View commit details
    Browse the repository at this point in the history

  7. Rename catch_expr feature to try_blocks

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    9f683be View commit details
    Browse the repository at this point in the history

  8. Update try-block tests to work under NLL

    @scottmcm
    scottmcm committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    5cf387c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Make a try-blocks folder for all the try{} UI tests

    @scottmcm
    scottmcm committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    e428085 View commit details
    Browse the repository at this point in the history

  2. Switch out another use of do catch

    @scottmcm
    scottmcm committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    0095471 View commit details
    Browse the repository at this point in the history