Fix loop label resolution around constants #52568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if that is just happening because of `abort_if_errors`
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
varkor
reviewed
Jul 21, 2018
src/librustc_errors/lib.rs
Outdated
| @@ -274,7 +274,7 @@ pub struct Handler { | |||
| err_count: AtomicUsize, | |||
| emitter: Lock<Box<dyn Emitter + sync::Send>>, | |||
| continue_after_error: LockCell<bool>, | |||
| delayed_span_bug: Lock<Option<Diagnostic>>, | |||
| delayed_span_bug: Lock<Vec<Diagnostic>>, | |||
There was a problem hiding this comment.
Perhaps this should be called delayed_span_bugs.
varkor
reviewed
Jul 21, 2018
| @@ -503,11 +519,18 @@ impl Handler { | |||
| } | |||
| pub fn delay_span_bug<S: Into<MultiSpan>>(&self, sp: S, msg: &str) { | |||
| if self.flags.treat_err_as_bug { | |||
| // FIXME: don't abort here if report_delayed_bugs is off | |||
There was a problem hiding this comment.
How straightforward is this to address in this PR?
There was a problem hiding this comment.
Oh it's easy. I just didn't want to change the default behaviour in this PR. ppl might get confused and not know about the extra flag you need to get the old behaviour back
|
@bors r+ |
|
📌 Commit bab5eb4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 5, 2024
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? `@oli-obk`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 5, 2024
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ``@oli-obk``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 5, 2024
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ```@oli-obk```
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 5, 2024
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ````@oli-obk````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2024
Rollup merge of rust-lang#119567 - nnethercote:rm-Zreport-delayed-bugs, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ````@oli-obk````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make
delay_span_buga little more helpfulr? @varkor
fixes #52442
fixes #52443