rustc: Stabilize #[wasm_import_module] as #[link(...)] #52445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @eddyb |
This was referenced Jul 16, 2018
|
@bors r+ |
|
📌 Commit 84a8796d85bf22150a792c6101945e462ecc840b has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #52353) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
alexcrichton
force-pushed
the
wasm-import-module
branch
from
84a8796 to
350cfb1
Compare
|
@bors: r=eddyb |
|
📌 Commit 350cfb15c8db938c026ff1cd479393ef35c1eda6 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- CI test failure ↑ |
bors
added
S-waiting-on-author
alexcrichton
force-pushed
the
wasm-import-module
branch
from
350cfb1 to
d30ba72
Compare
|
@bors: r=eddyb |
|
📌 Commit d30ba723ba237e805cf5d1d23b649096254a6462 has been approved by |
bors
added
S-waiting-on-bors
This commit stabilizes the `#[wasm_import_module]` attribute as `#[link(wasm_import_module = "...")]`. Tracked by rust-lang#52090 this new directive in the `#[link]` attribute is used to configured the module name that the imports are listed with. The WebAssembly specification indicates two utf-8 names are associated with all imported items, one for the module the item comes from and one for the item itself. The item itself is configurable in Rust via its identifier or `#[link_name = "..."]`, but the module name was previously not configurable and defaulted to `"env"`. This commit ensures that this is also configurable. Closes rust-lang#52090
alexcrichton
force-pushed
the
wasm-import-module
branch
from
d30ba72 to
b9024f8
Compare
|
@bors: r=eddyb |
|
📌 Commit b9024f8 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 20, 2018
rustc: Stabilize #[wasm_import_module] as #[link(...)] This commit stabilizes the `#[wasm_import_module]` attribute as `#[link(wasm_import_module = "...")]`. Tracked by #52090 this new directive in the `#[link]` attribute is used to configured the module name that the imports are listed with. The WebAssembly specification indicates two utf-8 names are associated with all imported items, one for the module the item comes from and one for the item itself. The item itself is configurable in Rust via its identifier or `#[link_name = "..."]`, but the module name was previously not configurable and defaulted to `"env"`. This commit ensures that this is also configurable. Closes #52090
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stabilizes the
#[wasm_import_module]attribute as#[link(wasm_import_module = "...")]. Tracked by #52090 this new directive inthe
#[link]attribute is used to configured the module name that the importsare listed with. The WebAssembly specification indicates two utf-8 names are
associated with all imported items, one for the module the item comes from and
one for the item itself. The item itself is configurable in Rust via its
identifier or
#[link_name = "..."], but the module name was previously notconfigurable and defaulted to
"env". This commit ensures that this is alsoconfigurable.
Closes #52090