Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgit2-sys to 0.7.3 #52017

Closed
wants to merge 1 commit into from
Closed

Conversation

heirecka
Copy link

@heirecka heirecka commented Jul 3, 2018

It imports a newer version of libgit2 which includes fixes to build
against LibreSSL 2.7.x.

It imports a newer version of libgit2 which includes fixes to build
against LibreSSL 2.7.x.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2018
@kennytm
Copy link
Member

kennytm commented Jul 3, 2018

Hi, thanks for the PR. This update has already been taken care of in #51917 which will be merged within days, so I'm closing this in favor of the other one.

@kennytm kennytm closed this Jul 3, 2018
@heirecka
Copy link
Author

heirecka commented Jul 3, 2018

Sorry, I wasn't aware of that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants