Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering cleanups [3/N] #51877

Merged
merged 4 commits into from
Jul 1, 2018
Merged

Lowering cleanups [3/N] #51877

merged 4 commits into from
Jul 1, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 28, 2018

Needs #51806 to be merged first

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 28, 2018

r? @cramertj

more stuff in lowering, sometimes touching async, commits in this PR start at b792ff8

@cramertj
Copy link
Member

Looks great! r=me once #51806 is merged.

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2018
@bors
Copy link
Contributor

bors commented Jun 30, 2018

☔ The latest upstream changes (presumably #51806) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 30, 2018

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Jun 30, 2018

📌 Commit 7879369 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 30, 2018
@bors
Copy link
Contributor

bors commented Jul 1, 2018

⌛ Testing commit 7879369 with merge a1703ba...

bors added a commit that referenced this pull request Jul 1, 2018
Lowering cleanups [3/N]

Needs #51806 to be merged first
@bors
Copy link
Contributor

bors commented Jul 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing a1703ba to master...

@bors bors merged commit 7879369 into rust-lang:master Jul 1, 2018
@oli-obk oli-obk deleted the lowering_cleanups3 branch June 15, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants