Bootstrap from 1.28.0 beta #51717

Mark-Simulacrum · 2018-06-22T15:49:45Z

No description provided.

rust-highfive · 2018-06-22T15:49:48Z

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

cuviper · 2018-06-22T16:29:45Z

Bootstrap from 1.27.0

Isn't this actually using 1.28.0-beta.1?

Mark-Simulacrum · 2018-06-22T16:41:38Z

Ah, yes, it is.

kennytm · 2018-06-25T08:29:40Z

Why not increase the CFG_RELEASE_NUM?

Mark-Simulacrum · 2018-06-25T12:20:50Z

@kennytm Fixed

kennytm · 2018-06-25T14:42:21Z

Assuming it's not waiting for other things...

@bors r+

bors · 2018-06-25T14:42:22Z

📌 Commit 21ac42514969a0d404f0b6ccd3c6be40c40dee02 has been approved by kennytm

kennytm · 2018-06-25T14:43:14Z

@bors p=1

Unblocks #51122 and #51677.

bors · 2018-06-25T15:58:00Z

⌛ Testing commit 21ac42514969a0d404f0b6ccd3c6be40c40dee02 with merge 41a0eb34ce2f8be23c0ba27b54587a45c22caefc...

bors · 2018-06-25T16:16:22Z

💔 Test failed - status-travis

rust-highfive · 2018-06-25T16:16:23Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:08:30] [RUSTC-TIMING] rustc_asan test:false 0.140
[00:08:30] [RUSTC-TIMING] rustc_tsan test:false 0.138
[00:08:31] [RUSTC-TIMING] rustc_msan test:false 0.109
[00:08:31] [RUSTC-TIMING] panic_unwind test:false 0.286
[00:08:36] warning: this feature has been stable since 1.28.0. Attribute no longer needed
[00:08:36]    --> libstd/lib.rs:337:21
[00:08:36]     |
[00:08:36] 337 |             feature(global_allocator))]
[00:08:36]     |
[00:08:36]     |
[00:08:36]     = note: #[warn(stable_features)] on by default
[00:08:44] [RUSTC-TIMING] std test:false 13.642
[00:08:44]     Finished release [optimized] target(s) in 46.82s
[00:08:44] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:08:44] travis_fold:end:stage0-std
---
[00:09:29] [RUSTC-TIMING] error_chain test:false 1.006
[00:09:29] [RUSTC-TIMING] xz2 test:false 0.823
[00:09:37] [RUSTC-TIMING] clap test:false 34.037
[00:09:37]    Compiling installer v0.0.0 (file:///checkout/src/tools/rust-installer)
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    |
[00:09:37]    = note: `-D renamed-and-removed-lints` implied by `-D warnings`
[00:09:37] 
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:38] error: aborting due to 4 previous errors
[00:09:38] 
[00:09:38] [RUSTC-TIMING] installer test:false 0.327
[00:09:38] error: Could not compile `installer`.
[00:09:38] 
[00:09:38] Caused by:
[00:09:38]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name installer tools/rust-installer/src/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=79b26711e46dfe03 -C extra-filename=-79b26711e46dfe03 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/release/deps --extern clap=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libclap-7119df03666f5ed3.rlib --extern error_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/liberror_chain-258cc1527e5f4ead.rlib --extern flate2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libflate2-6cb5b65c68ad4173.rlib --extern rayon=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/librayon-c037d3fb037d75f6.rlib --extern tar=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libtar-7cb0f036d782f810.rlib --extern walkdir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libwalkdir-29d660ed8698803f.rlib --extern xz2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libxz2-bfee124a30acf342.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/backtrace-sys-665ec07f5372f8b9/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/miniz-sys-b2da0adee48ee564/out -L /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/lzma-sys-90504555ddbe4295/out/lib` (exit code: 101)
[00:09:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rust-installer/Cargo.toml" "--features" "" "--message-format" "json"
[00:09:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:09:38] Build completed unsuccessfully in 0:06:24
travis_time:end:27359d8d:start=1529942698405373841,finish=1529943276837702719,duration=578432328878

---
travis_time:end:0797a4cc:start=1529943277625083109,finish=1529943277633839276,duration=8756167
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02f775d0
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0413c67a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-25T16:16:28Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:08:30] [RUSTC-TIMING] rustc_asan test:false 0.140
[00:08:30] [RUSTC-TIMING] rustc_tsan test:false 0.138
[00:08:31] [RUSTC-TIMING] rustc_msan test:false 0.109
[00:08:31] [RUSTC-TIMING] panic_unwind test:false 0.286
[00:08:36] warning: this feature has been stable since 1.28.0. Attribute no longer needed
[00:08:36]    --> libstd/lib.rs:337:21
[00:08:36]     |
[00:08:36] 337 |             feature(global_allocator))]
[00:08:36]     |
[00:08:36]     |
[00:08:36]     = note: #[warn(stable_features)] on by default
[00:08:44] [RUSTC-TIMING] std test:false 13.642
[00:08:44]     Finished release [optimized] target(s) in 46.82s
[00:08:44] Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[00:08:44] travis_fold:end:stage0-std
---
[00:09:29] [RUSTC-TIMING] error_chain test:false 1.006
[00:09:29] [RUSTC-TIMING] xz2 test:false 0.823
[00:09:37] [RUSTC-TIMING] clap test:false 34.037
[00:09:37]    Compiling installer v0.0.0 (file:///checkout/src/tools/rust-installer)
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    |
[00:09:37]    = note: `-D renamed-and-removed-lints` implied by `-D warnings`
[00:09:37] 
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:37] error: lint unused_doc_comment has been renamed to unused_doc_comments
[00:09:37]   --> tools/rust-installer/src/lib.rs:26:5
[00:09:37] 26 | /     error_chain!{
[00:09:37] 27 | |         foreign_links {
[00:09:37] 27 | |         foreign_links {
[00:09:37] 28 | |             Io(::std::io::Error);
[00:09:37] 29 | |             StripPrefix(::std::path::StripPrefixError);
[00:09:37] 30 | |             WalkDir(::walkdir::Error);
[00:09:37] 32 | |     }
[00:09:37]    | |_____^
[00:09:37]    |
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:09:37] 
[00:09:38] error: aborting due to 4 previous errors
[00:09:38] 
[00:09:38] [RUSTC-TIMING] installer test:false 0.327
[00:09:38] error: Could not compile `installer`.
[00:09:38] 
[00:09:38] Caused by:
[00:09:38]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name installer tools/rust-installer/src/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=79b26711e46dfe03 -C extra-filename=-79b26711e46dfe03 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/release/deps --extern clap=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libclap-7119df03666f5ed3.rlib --extern error_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/liberror_chain-258cc1527e5f4ead.rlib --extern flate2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libflate2-6cb5b65c68ad4173.rlib --extern rayon=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/librayon-c037d3fb037d75f6.rlib --extern tar=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libtar-7cb0f036d782f810.rlib --extern walkdir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libwalkdir-29d660ed8698803f.rlib --extern xz2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps/libxz2-bfee124a30acf342.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/backtrace-sys-665ec07f5372f8b9/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/miniz-sys-b2da0adee48ee564/out -L /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/build/lzma-sys-90504555ddbe4295/out/lib` (exit code: 101)
[00:09:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rust-installer/Cargo.toml" "--features" "" "--message-format" "json"
[00:09:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:09:38] Build completed unsuccessfully in 0:06:24
travis_time:end:27359d8d:start=1529942698405373841,finish=1529943276837702719,duration=578432328878

---
travis_time:end:0797a4cc:start=1529943277625083109,finish=1529943277633839276,duration=8756167
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02f775d0
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0413c67a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-06-25T16:29:30Z

@bors r=kennytm

bors · 2018-06-25T16:29:31Z

📌 Commit 1bccafdb3c8b6e97c862dee449023b9b59f2397a has been approved by kennytm

mati865 · 2018-06-25T16:35:46Z

error-chain was recently updated to 0.12 which should fix the issue.
I'll open PR for rustup and rust-installer.

bors · 2018-06-25T17:14:22Z

⌛ Testing commit 1bccafdb3c8b6e97c862dee449023b9b59f2397a with merge 5032ff2d8054fd30537fb4ac46cda4aa7471ba05...

rust-highfive · 2018-06-28T19:02:14Z

The job wasm32-unknown of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:15:25]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[01:15:25]    Compiling rand v0.4.2
[01:15:27] [RUSTC-TIMING] rand test:false 2.480
[01:16:03] [RUSTC-TIMING] core test:false 38.168
[01:16:03] error[E0523]: found two different crates with name `core` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
[01:16:03]   --> libcore/../libcore/tests/lib.rs:49:1
[01:16:03] 49 | extern crate core;
[01:16:03]    | ^^^^^^^^^^^^^^^^^^
[01:16:03] 
[01:16:03] error: aborting due to previous error
---
[01:16:03] 
[01:16:03] To learn more, run the command again with --verbose.
[01:16:03] 
[01:16:03] 
[01:16:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "wasm32-unknown-unknown" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--"
[01:16:03] 
[01:16:03] 
[01:16:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/run-pass src/test/compile-fail src/test/parse-fail src/test/mir-opt src/test/codegen-units src/libcore
[01:16:03] Build completed unsuccessfully in 1:13:03
---
travis_time:end:35cf3769:start=1530212414054333662,finish=1530212414060099895,duration=5766233
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01d2eef4
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05939c40
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-28T19:02:22Z

The job wasm32-unknown of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:15:25]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[01:15:25]    Compiling rand v0.4.2
[01:15:27] [RUSTC-TIMING] rand test:false 2.480
[01:16:03] [RUSTC-TIMING] core test:false 38.168
[01:16:03] error[E0523]: found two different crates with name `core` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
[01:16:03]   --> libcore/../libcore/tests/lib.rs:49:1
[01:16:03] 49 | extern crate core;
[01:16:03]    | ^^^^^^^^^^^^^^^^^^
[01:16:03] 
[01:16:03] error: aborting due to previous error
---
[01:16:03] 
[01:16:03] To learn more, run the command again with --verbose.
[01:16:03] 
[01:16:03] 
[01:16:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "wasm32-unknown-unknown" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--"
[01:16:03] 
[01:16:03] 
[01:16:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/run-pass src/test/compile-fail src/test/parse-fail src/test/mir-opt src/test/codegen-units src/libcore
[01:16:03] Build completed unsuccessfully in 1:13:03
---
travis_time:end:35cf3769:start=1530212414054333662,finish=1530212414060099895,duration=5766233
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01d2eef4
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05939c40
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-06-28T23:45:23Z

I've tried to track this issue down but so far been fairly unsuccessful in determining the root cause. We're generating what appears to be two different version of libcore but I can't tell where the one in the sysroot is coming from -- no other file matches its hash in the build directory.

This leads me to believe that either Cargo is overwriting files when generating the coretests -- this feels fairly likely considering that we see [RUSTC-TIMING] core test:false 38.168 in the build log right before the error, though core should not have been recompiled according to previous build logs.

I'm not sure why core is being recompiled -- what we should see is just coretests being compiled. It is unclear to me why Cargo compiles core, though it loosely looks like it could be somewhat of a bug. The below fingerprint error is the only one I see related to libcore in this invocation of Cargo, yet we see that cargo is building Target(lib)/Profile(release) ( INFO 2018-06-28T23:40:36Z: cargo::core::compiler::job_queue: start: core v0.0.0 (file:///checkout/src/libcore) => Target(lib)/Profile(release) => Target) -- without checking the fingerprint for that.

@alexcrichton -- is there a chance this is a Cargo bug? Or am I misreading/misinterpreting this output? Full log for the coretest compile: https://gist.github.com/Mark-Simulacrum/8121483a4484fe2477d9af4adb47d9cc

 INFO 2018-06-28T23:40:36Z: cargo::core::compiler::fingerprint: fingerprint error for core v0.0.0 (file:///checkout/src/libcore): failed to read `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/wasm32-unknown-unknown/release/.fingerprint/core-bd1cd8ef55dd7af8/test-integration-test-coretests-bd1cd8ef55dd7af8`

�[0KTesting core stage2 (x86_64-unknown-linux-gnu -> wasm32-unknown-unknown)
[01:13:25] �[0m�[0m�[1m�[32m   Compiling�[0m rand v0.4.2
[01:13:27] [RUSTC-TIMING] rand test:false 2.324
[01:13:27] �[0m�[0m�[1m�[32m   Compiling�[0m core v0.0.0 (file:///checkout/src/libcore)
[01:14:48] [RUSTC-TIMING] coretests test:true 81.272
[01:14:48] �[0m�[0m�[1m�[32m    Finished�[0m release [optimized] target(s) in 1m 23.89s
[01:14:48] �[0m�[0m�[1m�[32m     Running�[0m build/x86_64-unknown-linux-gnu/stage2-std/wasm32-unknown-unknown/release/deps/coretests-2918b84facad306a.wasm
[01:14:50] 	finished in 85.668
[01:14:50] travis_fold:end:test_stage2-core

currently:

rust/obj/build/x86_64-unknown-linux-gnu$ find . -name 'libcore*' | xargs sha1sum
222dfeeeec7438583c58f8f70eafebe21842314a  ./stage1-std/wasm32-unknown-unknown/release/libcore.rlib
222dfeeeec7438583c58f8f70eafebe21842314a  ./stage1-std/wasm32-unknown-unknown/release/deps/libcore-c3cb23bcc2322123.rlib
ca628c2a42e82d09e178ecd6132d77a2eef119be  ./stage1/lib/rustlib/wasm32-unknown-unknown/lib/libcore-c3cb23bcc2322123.rlib
a368e67761f1835d8b82e846b23c49218390981a  ./stage0-std/x86_64-unknown-linux-gnu/release/deps/libcore-8834350d01f8283c.rlib
82cf8fd73d016b0c68cffbc7f5a86f4bb83ea6c8  ./stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-27386c6ead892bb8.rlib
a368e67761f1835d8b82e846b23c49218390981a  ./stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-8834350d01f8283c.rlib

alexcrichton · 2018-06-29T14:26:05Z

Hm this does indeed look fishy! I think your diagnosis of rebuilding core is correct and I'm not sure why. I can't quite figure it out from the logs so I'm gonna dig in locally as well

There's a case where Cargo will recompile a project even if the fingerprint looks like it's fresh, when some output files are missing. This was intended to cover the case where an output file was deleted manually or otherwise messed with. The check here was a bit too eager, however. It checked not only the actual output destination of the compiler but *also* the location that we hard link the output file up to. Due to recent changes in rust-lang#5460 we don't always create the hard links for path dependencies in the top-level dir, and this meant that if the library were compiled and then tested later on the test may recompile the original library by accident. The fix in this commit is to cease looking for the hardlink if it exists or not. This way we only check for the presence of the output file itself and only recompile if that file is missing. The reason for this is that we unconditionally relink files into place whether it's fresh or not, so we'll always recreate the hard link anyway if it's missing. cc rust-lang/rust#51717

alexcrichton · 2018-06-29T19:22:58Z

Ok that bug should be fixed by rust-lang/cargo#5669 (confirmed locally) and once that Cargo PR lands we'll need to backport it and then make a new beta to update to here

Fix avoiding a rebuild when moving around a workspace There's a case where Cargo will recompile a project even if the fingerprint looks like it's fresh, when some output files are missing. This was intended to cover the case where an output file was deleted manually or otherwise messed with. The check here was a bit too eager, however. It checked not only the actual output destination of the compiler but *also* the location that we hard link the output file up to. Due to recent changes in #5460 we don't always create the hard links for path dependencies in the top-level dir, and this meant that if the library were compiled and then tested later on the test may recompile the original library by accident. The fix in this commit is to cease looking for the hardlink if it exists or not. This way we only check for the presence of the output file itself and only recompile if that file is missing. The reason for this is that we unconditionally relink files into place whether it's fresh or not, so we'll always recreate the hard link anyway if it's missing. cc rust-lang/rust#51717

There's a case where Cargo will recompile a project even if the fingerprint looks like it's fresh, when some output files are missing. This was intended to cover the case where an output file was deleted manually or otherwise messed with. The check here was a bit too eager, however. It checked not only the actual output destination of the compiler but *also* the location that we hard link the output file up to. Due to recent changes in rust-lang#5460 we don't always create the hard links for path dependencies in the top-level dir, and this meant that if the library were compiled and then tested later on the test may recompile the original library by accident. The fix in this commit is to cease looking for the hardlink if it exists or not. This way we only check for the presence of the output file itself and only recompile if that file is missing. The reason for this is that we unconditionally relink files into place whether it's fresh or not, so we'll always recreate the hard link anyway if it's missing. cc rust-lang/rust#51717

@alexcrichton

Fix avoiding a rebuild when moving around a workspace This is a backport of #5669. There's a case where Cargo will recompile a project even if the fingerprint looks like it's fresh, when some output files are missing. This was intended to cover the case where an output file was deleted manually or otherwise messed with. The check here was a bit too eager, however. It checked not only the actual output destination of the compiler but *also* the location that we hard link the output file up to. Due to recent changes in #5460 we don't always create the hard links for path dependencies in the top-level dir, and this meant that if the library were compiled and then tested later on the test may recompile the original library by accident. The fix in this commit is to cease looking for the hardlink if it exists or not. This way we only check for the presence of the output file itself and only recompile if that file is missing. The reason for this is that we unconditionally relink files into place whether it's fresh or not, so we'll always recreate the hard link anyway if it's missing. cc rust-lang/rust#51717 r? @alexcrichton

@alexcrichton

Previously Cargo would hardlink all the dependencies into the "root" as foo.dll and the `toplevel` array would get populated with these, but that's no longer the case. Instead, cargo will only do this for the final artifacts/final libraries. Rustbuild is updated to continue looping through the artifacts mentioned instead of early-returning. This should fix the bug. @alexcrichton found the cause of this and suggested this fix.

alexcrichton · 2018-06-30T20:18:04Z

@bors: r+

bors · 2018-06-30T20:18:04Z

📌 Commit 3d68774 has been approved by alexcrichton

bors · 2018-06-30T21:01:11Z

⌛ Testing commit 3d68774 with merge 48af771...

Bootstrap from 1.28.0 beta

bors · 2018-06-30T22:57:22Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 48af771 to master...

rust-highfive assigned bluss Jun 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2018

Mark-Simulacrum changed the title ~~Bootstrap from 1.27.0~~ Bootstrap from 1.28.0 beta Jun 22, 2018

Mark-Simulacrum force-pushed the snap branch from 6fed592 to b815d86 Compare June 22, 2018 16:42

Mark-Simulacrum force-pushed the snap branch from b815d86 to 21ac425 Compare June 25, 2018 12:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2018

Mark-Simulacrum force-pushed the snap branch from 21ac425 to 1bccafd Compare June 25, 2018 16:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2018

Keruspe mentioned this pull request Jun 29, 2018

cargo-install unnecessarily rebuilds everything rust-lang/cargo#5667

Closed

alexcrichton mentioned this pull request Jun 29, 2018

Fix avoiding a rebuild when moving around a workspace rust-lang/cargo#5669

Merged

Mark-Simulacrum mentioned this pull request Jun 29, 2018

Fix avoiding a rebuild when moving around a workspace rust-lang/cargo#5671

Merged

alexcrichton force-pushed the snap branch from 27f9db2 to 19c1d25 Compare June 30, 2018 20:17

Mark-Simulacrum added 2 commits June 30, 2018 13:17

Bootstrap from 1.28.0-beta.3

ad97f8b

alexcrichton force-pushed the snap branch from 19c1d25 to 3d68774 Compare June 30, 2018 20:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2018

bors added a commit that referenced this pull request Jun 30, 2018

Auto merge of #51717 - Mark-Simulacrum:snap, r=alexcrichton

48af771

Bootstrap from 1.28.0 beta

bors merged commit 3d68774 into rust-lang:master Jun 30, 2018

This was referenced Jun 30, 2018

Stabilize const_int_ops integer methods #51364

Closed

Update crates in Cargo.lock #51917

Merged

kennytm mentioned this pull request Jul 1, 2018

Update RLS and Rustfmt #51677

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstrap from 1.28.0 beta #51717

Bootstrap from 1.28.0 beta #51717

Mark-Simulacrum commented Jun 22, 2018

rust-highfive commented Jun 22, 2018

cuviper commented Jun 22, 2018

Mark-Simulacrum commented Jun 22, 2018

kennytm commented Jun 25, 2018

Mark-Simulacrum commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

bors commented Jun 25, 2018

rust-highfive commented Jun 25, 2018

rust-highfive commented Jun 25, 2018

Mark-Simulacrum commented Jun 25, 2018

bors commented Jun 25, 2018

mati865 commented Jun 25, 2018 •

edited

Loading

bors commented Jun 25, 2018

rust-highfive commented Jun 28, 2018

rust-highfive commented Jun 28, 2018

Mark-Simulacrum commented Jun 28, 2018

alexcrichton commented Jun 29, 2018

alexcrichton commented Jun 29, 2018

alexcrichton commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

Bootstrap from 1.28.0 beta #51717

Bootstrap from 1.28.0 beta #51717

Conversation

Mark-Simulacrum commented Jun 22, 2018

rust-highfive commented Jun 22, 2018

cuviper commented Jun 22, 2018

Mark-Simulacrum commented Jun 22, 2018

kennytm commented Jun 25, 2018

Mark-Simulacrum commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

bors commented Jun 25, 2018

rust-highfive commented Jun 25, 2018

rust-highfive commented Jun 25, 2018

Mark-Simulacrum commented Jun 25, 2018

bors commented Jun 25, 2018

mati865 commented Jun 25, 2018 • edited Loading

bors commented Jun 25, 2018

rust-highfive commented Jun 28, 2018

rust-highfive commented Jun 28, 2018

Mark-Simulacrum commented Jun 28, 2018

alexcrichton commented Jun 29, 2018

alexcrichton commented Jun 29, 2018

alexcrichton commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

mati865 commented Jun 25, 2018 •

edited

Loading