Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuchsia] Migrate from launchpad to fdio_spawn_etc #51359

Merged
merged 1 commit into from
Jun 9, 2018
Merged

[fuchsia] Migrate from launchpad to fdio_spawn_etc #51359

merged 1 commit into from
Jun 9, 2018

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Jun 5, 2018

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2018
@cramertj
Copy link
Member Author

cramertj commented Jun 5, 2018 •
edited
Loading

r? @sfackler I guess?

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 

[00:04:38] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:85: trailing whitespace
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:95: line longer than 100 chars
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:96: line longer than 100 chars
[00:04:40] some tidy checks failed
[00:04:40] 
[00:04:40] 
[00:04:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:40] 
[00:04:40] 
[00:04:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:40] Build completed unsuccessfully in 0:01:37
[00:04:40] Build completed unsuccessfully in 0:01:37
[00:04:40] Makefile:79: recipe for target 'tidy' failed
[00:04:40] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:019ac250
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@sfackler
Copy link
Member

sfackler commented Jun 5, 2018

Tidy failures, but r=me otherwise.

abarth
abarth reviewed Jun 5, 2018
View reviewed changes
src/libstd/sys/unix/process/zircon.rs Outdated

pub fn launchpad_vmo_from_file(filename: *const c_char) -> zx_handle_t;
}
pub const FDIO_SPAWN_SHARE_JOB: u32 = 0x0001;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We renamed FDIO_SPAWN_SHARE_JOB to FDIO_SPAWN_CLONE_JOB in the C header. Might be worth aligning here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

abarth
abarth reviewed Jun 5, 2018
View reviewed changes
src/libstd/sys/unix/process/process_fuchsia.rs Outdated
}
if let Some(fd) = stdio.stderr.fd() {
zx_cvt(launchpad_transfer_fd(launchpad, fd, 2))?;
let transfer_or_clone = |opt_fd, target_fd| if let Some(local_fd) = opt_fd {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cramertj
Copy link
Member Author

cramertj commented Jun 5, 2018

@bors r=sfackler

@bors
Copy link
Contributor

bors commented Jun 5, 2018

📌 Commit aa23aba has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 5, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51359 - cramertj:fdio_spawn, r=sfackler
5f2de72 
[fuchsia] Migrate from launchpad to fdio_spawn_etc

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 5, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 6, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51359 - cramertj:fdio_spawn, r=sfackler
86641c6 
[fuchsia] Migrate from launchpad to fdio_spawn_etc

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 6, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 7, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51359 - cramertj:fdio_spawn, r=sfackler
2733b0b 
[fuchsia] Migrate from launchpad to fdio_spawn_etc

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 7, 2018
Closed
@bors
Copy link
Contributor

bors commented Jun 7, 2018

⌛ Testing commit aa23aba with merge fc3ad51a9e906bf5690d03ff661c4fd6507f724b...

@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2018
@kennytm

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2018
@cramertj
[fuchsia] Migrate from launchpad to fdio_spawn_etc
0c6cd26 
fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.
@cramertj
Copy link
Member Author

cramertj commented Jun 7, 2018

@bors r=sfackler

@bors
Copy link
Contributor

bors commented Jun 7, 2018

📌 Commit 0c6cd26 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2018
@bors
Copy link
Contributor

bors commented Jun 8, 2018

⌛ Testing commit 0c6cd26 with merge b6b9886a757a40a910d5155f3c5c59b83428da1c...

@bors
Copy link
Contributor

bors commented Jun 8, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2018
@kennytm
Copy link
Member

kennytm commented Jun 8, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2018
@rust-lang rust-lang deleted a comment from rust-highfive Jun 8, 2018
bors added a commit that referenced this pull request Jun 9, 2018
@bors
Auto merge of #51359 - cramertj:fdio_spawn, r=sfackler
40f20b5 
[fuchsia] Migrate from launchpad to fdio_spawn_etc

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth
@bors
Copy link
Contributor

bors commented Jun 9, 2018

⌛ Testing commit 0c6cd26 with merge 40f20b5...

@bors
Copy link
Contributor

bors commented Jun 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 40f20b5 to master...

@bors bors merged commit 0c6cd26 into rust-lang:master Jun 9, 2018
@cramertj cramertj deleted the fdio_spawn branch June 11, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abarth abarth abarth left review comments

Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cramertj @rust-highfive @sfackler @bors @kennytm @abarth @withoutboats