Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #50546

Merged
merged 29 commits into from
May 9, 2018
Merged

Rollup of 11 pull requests #50546

merged 29 commits into from
May 9, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented May 8, 2018

Successful merges:

Failed merges:

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2018
@kennytm
Copy link
Member Author

kennytm commented May 8, 2018

@bors r+ p=12

@bors
Copy link
Contributor

bors commented May 8, 2018

📌 Commit 6a219ed has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
In the common case, the string value in a string literal Token is the
same as the string value in a string literal LitKind. (The exception is
when escapes or \r are involved.) This patch takes advantage of that to
avoid calling str_lit() and re-interning the string in that case. This
speeds up incremental builds for a few of the rustc-benchmarks, the best
by 3%.
@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit 6a219ed67f2a224537e1b4c1a7255bc00391eb91 with merge 7778ecaf985262b9bdbb325e2df7725e382a7f5c...

@bors
Copy link
Contributor

bors commented May 9, 2018

💔 Test failed - status-appveyor

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 9, 2018
@kennytm
Copy link
Member Author

kennytm commented May 9, 2018

@bors r+ bc503a0edd8a1b58f29089f5e9a181e25509cd00

@kennytm kennytm changed the title Rollup of 11 pull requests Rollup of 12 pull requests May 9, 2018
@kennytm
Copy link
Member Author

kennytm commented May 9, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2018

📌 Commit 0fd48d0 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2018
@bors
Copy link
Contributor

bors commented May 9, 2018

⌛ Testing commit 0fd48d027dbf250695ff2825042524e83fe1d3cc with merge 74594a505e26f64012f0731ad39aa38f59fabb4a...

@bors
Copy link
Contributor

bors commented May 9, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2018
kennytm added 6 commits May 9, 2018 20:29
Make `String::new()` const

Following the steps of rust-lang#50233 , make `String::new()` a `const fn`.
Added regression function match value test

closes rust-lang#44333
…avus

Add some explanations for #[must_use]

`#[must_use]` can be given a string argument which is shown whilst warning for things.

We should add a string argument to most of the user-exposed ones.

I added these for everything but the operators, mostly because I'm not sure what to write there or if we need anything there.
Cleanup a `use` in a raw_vec test

`allocator` is deprecated in favor of `alloc`, and `Alloc` is already imported
through `super::*`.
@kennytm kennytm changed the title Rollup of 12 pull requests Rollup of 11 pull requests May 9, 2018
@kennytm
Copy link
Member Author

kennytm commented May 9, 2018

@bors r+

Removed #50432.

@bors
Copy link
Contributor

bors commented May 9, 2018

📌 Commit 99cd9a9 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2018
@bors
Copy link
Contributor

bors commented May 9, 2018

⌛ Testing commit 99cd9a9 with merge ac287ed...

bors added a commit that referenced this pull request May 9, 2018
Rollup of 11 pull requests

Successful merges:

 - #49988 (Mention Result<!, E> in never docs.)
 - #50148 (turn `ManuallyDrop::new` into a constant function)
 - #50456 (Update the Cargo submodule)
 - #50460 (Make `String::new()` const)
 - #50464 (Remove some transmutes)
 - #50505 (Added regression function match value test)
 - #50511 (Add some explanations for #[must_use])
 - #50525 (Optimize string handling in lit_token().)
 - #50527 (Cleanup a `use` in a raw_vec test)
 - #50539 (Add more logarithm constants)
 - #49523 (Update RELEASES.md for 1.26.0)

Failed merges:
@bors
Copy link
Contributor

bors commented May 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing ac287ed to master...

@bors bors merged commit 99cd9a9 into rust-lang:master May 9, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.