-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some groundwork for cross-language LTO. #50000
Conversation
This comment has been minimized.
This comment has been minimized.
d83758e
to
0869f7b
Compare
@bors: r+ Looks great! |
📌 Commit 0869f7b has been approved by |
This comment has been minimized.
This comment has been minimized.
@bors r- (travis failing) |
@rust-lang/infra, |
I think that |
I can find |
I'm calling it like this:
So it should not need to be in |
Oh, but maybe we are not building LLVM ourselves in all cases? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8dc6599
to
56df629
Compare
@bors r=alexcrichton |
📌 Commit 56df629 has been approved by |
☔ The latest upstream changes (presumably #49972) made this pull request unmergeable. Please resolve the merge conflicts. |
56df629
to
34d58d7
Compare
Rebased. @bors r=alexcrichton |
📌 Commit 34d58d7 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
That's a blatantly spurious error. |
Add some groundwork for cross-language LTO. Implements part of #49879: - Adds a `-Z cross-lang-lto` flag to rustc - Makes sure that bitcode is embedded in object files if the flag is set. This should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However, `rustc` will not try to enable LTO for its own linker invocations yet. r? @alexcrichton
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Seems like @bors r=alexcrichton |
📌 Commit 0bf26bf has been approved by |
Add some groundwork for cross-language LTO. Implements part of #49879: - Adds a `-Z cross-lang-lto` flag to rustc - Makes sure that bitcode is embedded in object files if the flag is set. This should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However, `rustc` will not try to enable LTO for its own linker invocations yet. r? @alexcrichton
☀️ Test successful - status-appveyor, status-travis |
🎉 |
Implements part of #49879:
-Z cross-lang-lto
flag to rustcThis should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However,
rustc
will not try to enable LTO for its own linker invocations yet.r? @alexcrichton