-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove underscore_lifetimes
and match_default_bindings
from active feature list
#49647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Apr 4, 2018
Nominating for beta. These entries are also repeated in beta.
|
pietroalbini
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 4, 2018
Ping from triage @aturon! This PR needs your review. |
pietroalbini
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Apr 16, 2018
Ping from triage! Can @aturon or someone else from @rust-lang/compiler review this? |
@bors r+ rollup |
📌 Commit 3a55f2b has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 16, 2018
…e feature list These are already stabilized in 1.26.
kennytm
force-pushed
the
duplicated-features
branch
from
April 16, 2018 19:28
3a55f2b
to
6c3e1d7
Compare
@bors r=aturon |
📌 Commit 6c3e1d7 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 16, 2018
Remove `underscore_lifetimes` and `match_default_bindings` from active feature list These are already stabilized in 1.26.
bors
added a commit
that referenced
this pull request
Apr 16, 2018
Rollup of 8 pull requests Successful merges: - #49555 (Inline most of the code paths for conversions with boxed slices) - #49606 (Prevent broken pipes causing ICEs) - #49646 (Use box syntax instead of Box::new in Mutex::remutex on Windows) - #49647 (Remove `underscore_lifetimes` and `match_default_bindings` from active feature list) - #49931 (Fix incorrect span in `&mut` suggestion) - #49959 (rustbuild: allow building tools with debuginfo) - #49965 (Remove warning about f64->f32 cast being potential UB) - #49994 (Remove unnecessary indentation in rustdoc book codeblock.) Failed merges:
alexcrichton
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Apr 20, 2018
alexcrichton
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Apr 20, 2018
bors
added a commit
that referenced
this pull request
Apr 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already stabilized in 1.26.