-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hidden foo
functions from doc examples; use Termination
trait.
#49357
Remove hidden foo
functions from doc examples; use Termination
trait.
#49357
Conversation
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
3c8e7bf
to
ca8d233
Compare
r? @rust-lang/docs |
Are we sure we want to display the |
We do want to display |
for posterity, asked this in irc last week, here's the logs: https://botbot.me/mozilla/rust-docs/2018-03-21/?msg=98071184&page=1 |
Ah I see the goal now. Well sounds good to me, so unless someone else finds a bug, r=me. |
ca8d233
to
1d49a49
Compare
1d49a49
to
e9dcec0
Compare
@bors r=GuillaumeGomez rollup |
📌 Commit e9dcec0 has been approved by |
@bors rollup- p=113 Given the diff amount I think rolling it up might be quite risky. |
…GuillaumeGomez Remove hidden `foo` functions from doc examples; use `Termination` trait. Fixes #49233. Easier to review with the white-space ignoring `?w=1` feature: https://github.com/rust-lang/rust/pull/49357/files?w=1
☀️ Test successful - status-appveyor, status-travis |
Fixes #49233.
Easier to review with the white-space ignoring
?w=1
feature: https://github.com/rust-lang/rust/pull/49357/files?w=1