Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't pass -no-pie to gnu ld #49329

Merged
merged 1 commit into from
Mar 29, 2018
Merged

don't pass -no-pie to gnu ld #49329

merged 1 commit into from
Mar 29, 2018

Conversation

canarysnort01
Copy link
Contributor

fixes #48884

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2018
@davidalber davidalber mentioned this pull request Mar 24, 2018
Open
@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 28, 2018

📌 Commit 7cae6fe has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49329 - canarysnort01:fix-no-pie, r=pnkfelix
4285e1c 
don't pass -no-pie to gnu ld

fixes rust-lang#48884
@kennytm kennytm mentioned this pull request Mar 28, 2018
Merged
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49460 - kennytm:rollup, r=kennytm
d52c44e 
Rollup of 12 pull requests

- Successful merges: #49243, #49329, #49364, #49400, #49405, #49427, #49428, #49429, #49439, #49442, #49444, #49452
- Failed merges:
@bors bors merged commit 7cae6fe into rust-lang:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest changes in nightly cause it to produce executable named "-pie" in the crate directory.
4 participants
@canarysnort01 @rust-highfive @pnkfelix @bors