Fix Issue #48345, is_file, is_dir, and is_symlink note mutual exclusion #49076
Conversation
…l exclusion The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and `is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive. Fixes rust-lang#48345.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thank you for this PR @bobdavelisafrank! The triage team will periodically check in to make sure this PR is properly reviewed. Ping for @bluss! This PR needs your review. |
|
Thanks! @bors r+ rollup |
|
📌 Commit aaac69f has been approved by |
bors
added
S-waiting-on-bors
…docfix, r=bluss Fix Issue rust-lang#48345, is_file, is_dir, and is_symlink note mutual exclusion The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and `is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive. Fixes rust-lang#48345.
…docfix, r=bluss Fix Issue rust-lang#48345, is_file, is_dir, and is_symlink note mutual exclusion The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and `is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive. Fixes rust-lang#48345.
The methods on the structures
fs::FileTypeandfs::Metadataof (respectively)is_file,is_dir, andis_symlinkhad some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive.Fixes #48345.